This is an archive of the discontinued LLVM Phabricator instance.

Differential D28666

Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5
ClosedPublic

Authored by omjavaid on Jan 13 2017, 1:32 AM.

Details

Reviewers
tfiala
labath
Commits
rG56e70dd8cf54: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5
rLLDB291949: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5
rL291949: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5
Summary

TestRegisterVariables fails with O1 level when using gcc version 5.0 or above on arm/arm64 linux targets.

The reason is injection of buffer overflow protection code at O level 1. This patch turns off buffer overflow protection code by turning off FORTIFY_SOURCE.

Can we commit this if nothing goes wrong on any other target. ?

Diff Detail

Repository
rL LLVM

Event Timeline

omjavaid updated this revision to Diff 84257.Jan 13 2017, 1:32 AM
omjavaid retitled this revision from to Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5.
omjavaid updated this object.
omjavaid added reviewers: tfiala, labath.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson. · View Herald TranscriptJan 13 2017, 1:32 AM
labath accepted this revision.Jan 13 2017, 1:43 AM
labath edited edge metadata.

Seems reasonable. Maybe add a comment explaining why is that macro defined.

This test is incredibly brittle. I think we should find a better way to test the feature, but I don't really have a good idea so far...

This revision is now accepted and ready to land.Jan 13 2017, 1:43 AM
Closed by commit rL291949: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5 (authored by omjavaid). · Explain WhyJan 13 2017, 11:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
packages/
Python/
lldbsuite/
test/
lang/
c/
register_variables/
2 lines

Diff 84342

lldb/trunk/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile

LEVEL = ../../../make LEVEL = ../../../make
C_SOURCES := test.c C_SOURCES := test.c
CFLAGS_EXTRAS += -O1 CFLAGS_EXTRAS += -O1 -D_FORTIFY_SOURCE=0
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules