Page MenuHomePhabricator

Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5
ClosedPublic

Authored by omjavaid on Jan 13 2017, 1:32 AM.

Details

Summary

TestRegisterVariables fails with O1 level when using gcc version 5.0 or above on arm/arm64 linux targets.

The reason is injection of buffer overflow protection code at O level 1. This patch turns off buffer overflow protection code by turning off FORTIFY_SOURCE.

Can we commit this if nothing goes wrong on any other target. ?

Diff Detail

Repository
rL LLVM

Event Timeline

omjavaid updated this revision to Diff 84257.Jan 13 2017, 1:32 AM
omjavaid retitled this revision from to Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5.
omjavaid updated this object.
omjavaid added reviewers: tfiala, labath.
omjavaid added a subscriber: lldb-commits.
labath accepted this revision.Jan 13 2017, 1:43 AM
labath edited edge metadata.

Seems reasonable. Maybe add a comment explaining why is that macro defined.

This test is incredibly brittle. I think we should find a better way to test the feature, but I don't really have a good idea so far...

This revision is now accepted and ready to land.Jan 13 2017, 1:43 AM
This revision was automatically updated to reflect the committed changes.