This is an archive of the discontinued LLVM Phabricator instance.

lib/Fuzzer/test/coverage.test
6 ↗	(On Diff #84213)	A couple of alternatives: Check whether this line would work: `CHECK: COVERED_DIRS: %S` Use `%{pathsep}` instead of the regex. `CHECK: COVERED_DIRS: {{.*}}lib%{pathsep}Fuzzer%{pathsep}test` The first would be ideal, but if the output only prints a relative path and not an absolute path, it won't work since `%S` uses an absolute path.

@zturner, Great to know that I can use: %{pathsep} , I looked for something similar in the documentation but I didn't find it. Thanks.

mpividori added inline comments.Jan 17 2017, 8:45 PM

lib/Fuzzer/test/coverage.test
6 ↗	(On Diff #84213)	@zturner I think we need to use `{{[/\\]}}`. I see that many tests use that. We can't use `%S` and `%{pathsep}`, because they can only be used inside `RUN:` lines, because they are replaced by `lit`, not by `FileCheck`.

Thanks for trying. lgtm

This revision is now accepted and ready to land.Jan 17 2017, 8:52 PM

Closed by commit rL292740: [libFuzzer] Consider both possible separators for tests. (authored by mpividori). · Explain WhyJan 21 2017, 6:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

Fuzzer/

test/

coverage.test

2 lines

Diff 85261

llvm/trunk/lib/Fuzzer/test/coverage.test

	CHECK: COVERAGE:			CHECK: COVERAGE:
	CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:13			CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:13
	CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:14			CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:14
	CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:16			CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:16
	CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:19			CHECK-DAG: COVERED: {{.}}in LLVMFuzzerTestOneInput {{.}}NullDerefTest.cpp:19
	CHECK: COVERED_DIRS: {{.*}}lib/Fuzzer/test			CHECK: COVERED_DIRS: {{.*}}lib{{[/\\]}}Fuzzer{{[/\\]}}test
	RUN: not LLVMFuzzer-NullDerefTest -print_coverage=1 2>&1 \| FileCheck %s			RUN: not LLVMFuzzer-NullDerefTest -print_coverage=1 2>&1 \| FileCheck %s

	RUN: LLVMFuzzer-DSOTest -print_coverage=1 -runs=0 2>&1 \| FileCheck %s --check-prefix=DSO			RUN: LLVMFuzzer-DSOTest -print_coverage=1 -runs=0 2>&1 \| FileCheck %s --check-prefix=DSO
	DSO: COVERAGE:			DSO: COVERAGE:
	DSO-DAG: COVERED:{{.}}DSO1{{.}}DSO1.cpp			DSO-DAG: COVERED:{{.}}DSO1{{.}}DSO1.cpp
	DSO-DAG: COVERED:{{.}}DSO2{{.}}DSO2.cpp			DSO-DAG: COVERED:{{.}}DSO2{{.}}DSO2.cpp
	DSO-DAG: COVERED:{{.}}LLVMFuzzerTestOneInput{{.}}DSOTestMain			DSO-DAG: COVERED:{{.}}LLVMFuzzerTestOneInput{{.}}DSOTestMain
	DSO-DAG: UNCOVERED_LINE:{{.}}DSO1{{.}}DSO1.cpp			DSO-DAG: UNCOVERED_LINE:{{.}}DSO1{{.}}DSO1.cpp
	DSO-DAG: UNCOVERED_LINE:{{.}}DSO2{{.}}DSO2.cpp			DSO-DAG: UNCOVERED_LINE:{{.}}DSO2{{.}}DSO2.cpp
	DSO-DAG: UNCOVERED_FUNC: in Uncovered1			DSO-DAG: UNCOVERED_FUNC: in Uncovered1
	DSO-DAG: UNCOVERED_FUNC: in Uncovered2			DSO-DAG: UNCOVERED_FUNC: in Uncovered2
	DSO-DAG: UNCOVERED_LINE: in LLVMFuzzerTestOneInput			DSO-DAG: UNCOVERED_LINE: in LLVMFuzzerTestOneInput
	DSO-DAG: UNCOVERED_FILE:{{.*}}DSOTestExtra.cpp			DSO-DAG: UNCOVERED_FILE:{{.*}}DSOTestExtra.cpp

This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Fix coverage tests for Windows.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 85261

llvm/trunk/lib/Fuzzer/test/coverage.test

[libFuzzer] Fix coverage tests for Windows.
ClosedPublic