Page MenuHomePhabricator

Guard __gnuc_va_list typedef
ClosedPublic

Authored by probinson on Jan 12 2017, 11:28 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

probinson updated this revision to Diff 84151.Jan 12 2017, 11:28 AM
probinson retitled this revision from to Guard __gnuc_va_list typedef.
probinson updated this object.
probinson added a reviewer: yaron.keren.
probinson added a subscriber: cfe-commits.

I think the fix/test looks good, but someone with more experience than me should review it before accepting it

yaron.keren accepted this revision.Jan 21 2017, 7:22 PM

LGTM, matches the code in libstdc++ stdarg,h.
You can remove the 'hack' comment in line 46, __GNUC_VA_LIST is just a standard include guard for the typedef.

This revision is now accepted and ready to land.Jan 21 2017, 7:22 PM
This revision was automatically updated to reflect the committed changes.