This is an archive of the discontinued LLVM Phabricator instance.

Differential D28607

[ELF] avoid 'invalid-noreturn' error.
ClosedPublic

Authored by ioeric on Jan 12 2017, 5:18 AM.

Details

Reviewers
grimar
Commits
rGb45c0d4ff00d: [ELF] avoid 'invalid-noreturn' error.
rLLD291766: [ELF] avoid 'invalid-noreturn' error.
rL291766: [ELF] avoid 'invalid-noreturn' error.
Summary

elf::fatal is declared "noreturn".

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric updated this revision to Diff 84113.Jan 12 2017, 5:18 AM
ioeric retitled this revision from to [ELF] avoid 'invalid-noreturn' error..
ioeric updated this object.
ioeric added a reviewer: grimar.
ioeric added a subscriber: llvm-commits.
grimar accepted this revision.Jan 12 2017, 5:20 AM
grimar edited edge metadata.

LGTM. Thanks !

This revision is now accepted and ready to land.Jan 12 2017, 5:20 AM
Closed by commit rL291766: [ELF] avoid 'invalid-noreturn' error. (authored by ioeric). · Explain WhyJan 12 2017, 5:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
ELF/
4 lines

Diff 84115

lld/trunk/ELF/Error.cpp

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesvoid elf::fatal(const Twine &Msg) {
exitLld(1); exitLld(1);
} }
void elf::fatal(std::error_code EC, const Twine &Prefix) { void elf::fatal(std::error_code EC, const Twine &Prefix) {
fatal(Prefix + ": " + EC.message()); fatal(Prefix + ": " + EC.message());
} }
void elf::fatal(Error &E, const Twine &Prefix) { void elf::fatal(Error &E, const Twine &Prefix) {
handleAllErrors(std::move(E), [&](llvm::ErrorInfoBase &EI) { fatal(Prefix + ": " + llvm::toString(std::move(E)));
fatal(Prefix + ": " + EI.message());
});
} }
} // namespace lld } // namespace lld