This is an archive of the discontinued LLVM Phabricator instance.

Skip loop header when we can computing loop safety info
ClosedPublic

Authored by trentxintong on Jan 9 2017, 9:44 PM.

Details

Reviewers
hfinkel
Summary

Skip loop header when we can computing loop safety info

Event Timeline

trentxintong retitled this revision from to Skip loop header when we can computing loop safety info.
trentxintong updated this object.
trentxintong added a reviewer: hfinkel.
trentxintong added a subscriber: llvm-commits.

Move declaration into forloop.

hfinkel added inline comments.Jan 10 2017, 5:36 AM
lib/Transforms/Scalar/LICM.cpp
450–453

Comment on why you're skipping the header.

Address comments.

@hfinkel Are there still concerns with this ? Thanks.

hfinkel accepted this revision.Jan 17 2017, 2:09 PM

@hfinkel Are there still concerns with this ? Thanks.

Nope. LGTM.

This revision is now accepted and ready to land.Jan 17 2017, 2:09 PM
trentxintong closed this revision.Jan 17 2017, 4:27 PM

I lost the branch. committed in 292310.