Page MenuHomePhabricator

[CodeGen] Implement the SUnit::print() method
ClosedPublic

Authored by evandro on Jan 9 2017, 3:02 PM.

Details

Summary

The print() method seems to have had a troubled life. This patch proposes that it replaces the recently added helper local function dumpSUIdentifier(). This way, the method can be used in other files using the SUnit class.

Diff Detail

Repository
rL LLVM

Event Timeline

evandro updated this revision to Diff 83709.Jan 9 2017, 3:02 PM
evandro retitled this revision from to [CodeGen] Implement the SUnit::print() method.
evandro updated this object.
evandro added reviewers: atrick, sunfish, MatzeB.
evandro set the repository for this revision to rL LLVM.
evandro added a subscriber: llvm-commits.
atrick edited edge metadata.Jan 9 2017, 3:22 PM

Looks reasonable to me.

MatzeB accepted this revision.Jan 9 2017, 3:25 PM
MatzeB edited edge metadata.

LGTM

llvm/lib/CodeGen/ScheduleDAG.cpp
313 ↗(On Diff #83709)

Most of the other code uses OS and DAG as variable names for these.

This revision is now accepted and ready to land.Jan 9 2017, 3:25 PM
evandro marked an inline comment as done.Jan 9 2017, 3:42 PM
This revision was automatically updated to reflect the committed changes.