This is an archive of the discontinued LLVM Phabricator instance.

[sancov] introducing SANCOV_OPTIONS
ClosedPublic

Authored by aizatsky on Jan 4 2017, 12:55 PM.

Details

Summary

At this point SANCOV_OPTIONS are not functional but it is our intent
to move here sanitizer coverage flags from various sanitizers _OPTIONS.

Diff Detail

Repository
rL LLVM

Event Timeline

aizatsky updated this revision to Diff 83110.Jan 4 2017, 12:55 PM
aizatsky retitled this revision from to [sancov] introducing SANCOV_OPTIONS.
aizatsky updated this object.
aizatsky added a reviewer: kcc.
kcc added inline comments.Jan 4 2017, 1:56 PM
lib/sanitizer_common/sancov_flags.h
1 ↗(On Diff #83110)

It's time to create a separate dir for this (lib/sancov?) and move sanitizer_coverage_libcdep_new.cc and this file there
All files in sanitizer_common are named sanitizer_*, so sancov_* might be confusing.
Besides, we need a separate dir anyway, to support windows (afaict)

31 ↗(On Diff #83110)

sancov_flags?

aizatsky updated this revision to Diff 83131.Jan 4 2017, 2:00 PM

flags -> sancov_flags

aizatsky marked an inline comment as done.Jan 4 2017, 2:02 PM
aizatsky added inline comments.
lib/sanitizer_common/sancov_flags.h
1 ↗(On Diff #83110)

It's time to create a separate dir for this (lib/sancov?) and move sanitizer_coverage_libcdep_new.cc and this file there

I would prefer to do it in a separate change if you do not mind.

All files in sanitizer_common are named sanitizer_*, so sancov_* might be confusing.

After the move it will become ok, right?

kcc accepted this revision.Jan 4 2017, 5:20 PM
kcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 4 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.