Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Do we consider enum helpers?
clang-move/ClangMove.cpp | ||
---|---|---|
171 ↗ | (On Diff #82857) | These 3 lines seen to be repeated. Maybe pull them out as a MoveTool method? |
This patch excludes enum helpers, only considers the enum declarations which are defined in old.h.
Ideally, we should support enum helpers which are defined in old.cc, but that's another topic.
clang-move/ClangMove.cpp | ||
---|---|---|
171 ↗ | (On Diff #82857) | Done. I made a function for these repeated lines, but it seems hard to figure out a pretty name for it. |
I mean, if a enum helper used in say only old cc, will it be moved? The question is related to D27673. You don't need to support enum helper now, but it would be nice to drop a comment somewhere.
clang-move/ClangMove.h | ||
---|---|---|
140 ↗ | (On Diff #82872) | Maybe just addMovedDecl? move indicates move and delete IMO. But you might need to explain what's really going on in the comment. |
Done. Add a comment about this. Enum helpers will not moved whether they are used or not.
clang-move/ClangMove.h | ||
---|---|---|
140 ↗ | (On Diff #82872) | Instead of making an interface in the class, I put this function as a helper function in .cc, and named it as MoveDeclFromOldFileToNewFile. Hope this will make it clearer. |