This is an archive of the discontinued LLVM Phabricator instance.

[doc] Fix minor grammatical error in Phabricator.rst
ClosedPublic

Authored by anmol on Jan 1 2017, 4:37 PM.

Reviewers

Commits

Summary

Test commit, fix minor grammatical error in Phabricator.rst

anmol retitled this revision from to [doc] Fix minor grammatical error in Phabricator.rst.

anmol updated this object.

anmol added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Jan 2 2017, 2:40 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

docs/

2 lines

	Show First 20 Lines • Show All 126 Lines • ▼ Show 20 Lines
	Committing a change			Committing a change
	-------------------			-------------------

	Once a patch has been reviewed and approved on Phabricator it can then be			Once a patch has been reviewed and approved on Phabricator it can then be
	committed to trunk. If you do not have commit access, someone has to			committed to trunk. If you do not have commit access, someone has to
	commit the change for you (with attribution). It is sufficient to add			commit the change for you (with attribution). It is sufficient to add
	a comment to the approved review indicating you cannot commit the patch			a comment to the approved review indicating you cannot commit the patch
	yourself. If you have commit access, there are multiple workflows to commit the			yourself. If you have commit access, there are multiple workflows to commit the
	change. Whichever method you follow it is recommend that your commit message			change. Whichever method you follow it is recommended that your commit message
	ends with the line:			ends with the line:

	::			::

	Differential Revision: <URL>			Differential Revision: <URL>

	where ``<URL>`` is the URL for the code review, starting with			where ``<URL>`` is the URL for the code review, starting with
	``http://reviews.llvm.org/``.			``http://reviews.llvm.org/``.
	▲ Show 20 Lines • Show All 95 Lines • Show Last 20 Lines