This is an archive of the discontinued LLVM Phabricator instance.

remove some visibility attributes/DLL storage
ClosedPublic

Authored by compnerd on Dec 30 2016, 4:24 PM.

Details

Reviewers
EricWF
smeenai
Summary

When building libc++ with clang-cl, the duplicated annotation of these methods would cause an error.

cannot apply 'dllexport' to a 'dllexport' class

Since the class is already marked with the appropriate attribute, the function should inherit the visibility/DLL storage. Remove the secondary annotation.

Diff Detail

Repository
rL LLVM

Event Timeline

compnerd updated this revision to Diff 82749.Dec 30 2016, 4:24 PM
compnerd retitled this revision from to remove some visibility attributes/DLL storage.
compnerd updated this object.
compnerd added reviewers: EricWF, smeenai.
compnerd set the repository for this revision to rL LLVM.
compnerd added a subscriber: llvm-commits.
smeenai accepted this revision.Dec 30 2016, 4:26 PM
smeenai edited edge metadata.

You beat me to this :)

This revision is now accepted and ready to land.Dec 30 2016, 4:26 PM
compnerd closed this revision.Dec 31 2016, 9:45 AM

SVN r290785