This is an archive of the discontinued LLVM Phabricator instance.

[GlobalValue] Move HasLLVMReservedName into existing bitfield. NFC
ClosedPublic

Authored by jlebar on Dec 28 2016, 4:32 PM.

Details

Summary

Follow-up to r290691, where I introduced HasLLVMReservedName. rnk
pointed out that that patch added an extra word to GlobalValue on MSVC,
because it doesn't pack bitfields with different types.

This patch moves HasLLVMReservedName into the existing bitfield, where
we appear to have plenty of bits to spare.

Event Timeline

jlebar updated this revision to Diff 82629.Dec 28 2016, 4:32 PM
jlebar retitled this revision from to [GlobalValue] Move HasLLVMReservedName into existing bitfield. NFC.
jlebar updated this object.
jlebar added a reviewer: rnk.
jlebar added a subscriber: llvm-commits.
rnk accepted this revision.Dec 28 2016, 4:37 PM
rnk edited edge metadata.

lgtm, thanks!

This revision is now accepted and ready to land.Dec 28 2016, 4:37 PM
This revision was automatically updated to reflect the committed changes.