We currently limit the length of TSan returned backtraces to 8, which is not necessary (and a bug, most likely). Let's remove this.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Looks fine to me, the only reason I could think to cap it is if the method used to backtrace the thread could get stuck in a loop & provide infinite number of frames. but we could have crashed earlier than this if that happened, so I'm not concerned.
Comment Actions
We're dealing with ValueObjects here, so assuming GetNumChildren() returns a valid number of children, I think this cannot cause any issues.