Page MenuHomePhabricator

Stop limiting the number of TSan backtrace size to 8
ClosedPublic

Authored by kubamracek on Dec 21 2016, 3:09 PM.

Details

Summary

We currently limit the length of TSan returned backtraces to 8, which is not necessary (and a bug, most likely). Let's remove this.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 82280.Dec 21 2016, 3:09 PM
kubamracek retitled this revision from to Stop limiting the number of TSan backtrace size to 8.
kubamracek updated this object.
kubamracek added reviewers: jasonmolenda, clayborg.
kubamracek added a project: Restricted Project.
kubamracek added subscribers: lldb-commits, zaks.anna.
jasonmolenda accepted this revision.Dec 21 2016, 3:19 PM
jasonmolenda edited edge metadata.

Looks fine to me, the only reason I could think to cap it is if the method used to backtrace the thread could get stuck in a loop & provide infinite number of frames. but we could have crashed earlier than this if that happened, so I'm not concerned.

This revision is now accepted and ready to land.Dec 21 2016, 3:19 PM

We're dealing with ValueObjects here, so assuming GetNumChildren() returns a valid number of children, I think this cannot cause any issues.

clayborg accepted this revision.Dec 21 2016, 3:51 PM
clayborg edited edge metadata.
This revision was automatically updated to reflect the committed changes.