[LLD] Use cpio -it instead of cpio -t

[kettenis]

Summary

OpenBSD's cpio does not accept the -t option without -i.
Apparently some systems implement cpio -t as a shortcut
for cpio -it, the latter is the only thing that's documented.
This change avoids test failures on OpenBSD.

[grimar]

Not relative to this patch, just a hint:

I think you want to add the reviewers to the patches you posting. Otherwise your patches are still visible on llvm-mails,
but reviewers do not get a direct mail and can probably just lose it.

For LLD Rui and Rafael are usually good candidates to add.

[davide]

I guess this is fine, but please make sure the test doesn't fail on Windows.

[grimar]

I can confirm that passes tests on windows for me. (I am using GnuWin32)

[davide]

Fair enough. @kettenis out of curiosity, you know why OpenBSD doesn't implement this shortcut?

[kettenis]

My guess is that it is an (undocumented) GNU extension. FreeBSD's libarchive-based cpio obviously attempts to implement the GNU extensions.
OpenBSD used a different cpio implementation inherited from NetBSD, and we generally avoid implementing GNU extensions to encourage our
users to write portable code/scripts. FWIW, the Solaris cpio doesn't accept -t without -i either.

[davide]

Committed thusly, thanks for your contribution.

Commit this patch to SVN? ([y]es (default)|[n]o|[q]uit|[a]ll): y

M       test/ELF/reproduce-backslash.s
M       test/ELF/reproduce-windows.s
M       test/ELF/reproduce.s

Committed r290252

lld/trunk/test/ELF/reproduce-backslash.s

 # REQUIRES: x86, cpio, shell
 
 # Test that we don't erroneously replace \ with / on UNIX, as it's
 # legal for a filename to contain backslashes.
 # RUN: llvm-mc %s -o foo\\.o -filetype=obj -triple=x86_64-pc-linux
 # RUN: ld.lld foo\\.o --reproduce repro
-# RUN: cpio -t < repro.cpio | FileCheck %s
+# RUN: cpio -it < repro.cpio | FileCheck %s
 
 # CHECK: repro/{{.*}}/foo\.o

lld/trunk/test/ELF/reproduce-windows.s

 # REQUIRES: x86, cpio
 
 # Test that a repro archive always uses / instead of \.
 # RUN: rm -rf %t.dir
 # RUN: mkdir -p %t.dir/build
 # RUN: llvm-mc %s -o %t.dir/build/foo.o -filetype=obj -triple=x86_64-pc-linux
 # RUN: cd %t.dir
 # RUN: ld.lld build/foo.o --reproduce repro
-# RUN: cpio -t < repro.cpio | FileCheck %s
+# RUN: cpio -it < repro.cpio | FileCheck %s
 
 # CHECK: repro/response.txt
 # CHECK: repro/{{.*}}/build/foo.o

lld/trunk/test/ELF/reproduce.s

 # RSP2-NEXT: --dynamic-list {{.+}}dyn
 # RSP2-NEXT: -rpath {{.+}}file
 # RSP2-NEXT: --script {{.+}}file
 # RSP2-NEXT: --version-script [[PATH:.*]]ver
 # RSP2-NEXT: --dynamic-linker "some unusual/path"
 # RSP2-NEXT: -soname="foo bar"
 # RSP2-NEXT: -soname="foo bar"
 
-# RUN: cpio -t < repro2.cpio | FileCheck %s
+# RUN: cpio -it < repro2.cpio | FileCheck %s
 # CHECK:      repro2/response.txt
 # CHECK-NEXT: repro2/version.txt
 # CHECK-NEXT: repro2/{{.*}}/dyn
 # CHECK-NEXT: repro2/{{.*}}/ver
 # CHECK-NEXT: repro2/{{.*}}/foo bar
 # CHECK-NEXT: repro2/{{.*}}/file2
 # CHECK-NEXT: repro2/{{.*}}/file
 
 .globl _start
 _start:
   mov $60, %rax
   mov $42, %rdi
   syscall