This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Diff 29 - [AflDriver] Separate implementations of GetPeakRSSMb() for diff platforms.
AbandonedPublic

Authored by mpividori on Dec 19 2016, 9:03 AM.

Details

Reviewers
kcc
zturner
Summary

As far as I understand, the goal is to have only one file for afl_driver and make it self contained, even if we are repeating code from libFuzzer.
Taking that into account, I include the following modifications using macros inside afl_driver, to support different platforms.

As this code is the same than for libFuzzer, I would strongly prefer to develop a common static library: "FuzzerSupport", including all the IO and Utils functionalities. Then we could link against that library for libFuzzer and for the afl_driver.
I would like to know your opinion on this.
It would be very simple to add a cmake dependency: "target_link(AFLDriver FuzzerSupport)"
Also, I would like to update the code to remove the flags: LIBFUZZER_POSIX, LIBFUZZER_WINDOWS, etc. and move that logic to the cmake files.

Thanks

Diff Detail

Repository
rL LLVM

Event Timeline

mpividori updated this revision to Diff 81960.Dec 19 2016, 9:03 AM
mpividori retitled this revision from to [libFuzzer] Diff 29 - Separate implementations of GetPeakRSSMb() for diff platforms..
mpividori updated this object.
mpividori added reviewers: kcc, zturner.
mpividori set the repository for this revision to rL LLVM.
mpividori added a subscriber: llvm-commits.
zturner accepted this revision.Dec 19 2016, 9:37 AM
zturner edited edge metadata.

This one lgtm.

This revision is now accepted and ready to land.Dec 19 2016, 9:37 AM
mpividori retitled this revision from [libFuzzer] Diff 29 - Separate implementations of GetPeakRSSMb() for diff platforms. to [libFuzzer] [AflDriver] Diff 29 - Separate implementations of GetPeakRSSMb() for diff platforms..Dec 21 2016, 8:48 AM
mpividori edited edge metadata.
mpividori retitled this revision from [libFuzzer] [AflDriver] Diff 29 - Separate implementations of GetPeakRSSMb() for diff platforms. to [libFuzzer] Diff 29 - [AflDriver] Separate implementations of GetPeakRSSMb() for diff platforms..
mpividori abandoned this revision.Jan 4 2017, 6:09 PM