This is an archive of the discontinued LLVM Phabricator instance.

Differential D27915

Add missing includes on Windows.
ClosedPublic

Authored by halyavin on Dec 19 2016, 1:14 AM.

Details

Reviewers
zturner
labath
Commits
rGab266cf95beb: Add missing includes on Windows.
rL290263: Add missing includes on Windows.
Summary

Add proper includes according to MSDN documentation.

_byteswap_* needs stdlib.h
_CrtSetReportHook needs crtdbg.h

Diff Detail

Event Timeline

halyavin updated this revision to Diff 81926.Dec 19 2016, 1:14 AM
halyavin retitled this revision from to Add missing includes on Windows..
halyavin updated this object.
halyavin added reviewers: zturner, labath.
halyavin added a comment.Dec 19 2016, 1:16 AM
  • _byteswap_* needs stdlib.h
  • _CrtSetReportHook needs crtdbg.h
zturner accepted this revision.Dec 19 2016, 9:31 AM
zturner edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2016, 9:32 AM
halyavin updated this object.Dec 19 2016, 9:50 PM
halyavin edited edge metadata.

Could you please commit this change? I don't have commit access.

halyavin added a comment.Dec 21 2016, 10:57 AM

ping

Closed by commit rL290263: Add missing includes on Windows. (authored by zturner). · Explain WhyDec 21 2016, 11:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
Support/
3 lines
lib/
Support/
Windows/
1 line

Diff 81926

include/llvm/Support/SwapByteOrder.h

Show All 12 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_SUPPORT_SWAPBYTEORDER_H #ifndef LLVM_SUPPORT_SWAPBYTEORDER_H
#define LLVM_SUPPORT_SWAPBYTEORDER_H #define LLVM_SUPPORT_SWAPBYTEORDER_H
#include "llvm/Support/Compiler.h" #include "llvm/Support/Compiler.h"
#include "llvm/Support/DataTypes.h" #include "llvm/Support/DataTypes.h"
#include <cstddef> #include <cstddef>
#if defined(_MSC_VER) && !defined(_DEBUG)
#include <stdlib.h>
#endif
namespace llvm { namespace llvm {
namespace sys { namespace sys {
/// SwapByteOrder_16 - This function returns a byte-swapped representation of /// SwapByteOrder_16 - This function returns a byte-swapped representation of
/// the 16-bit argument. /// the 16-bit argument.
inline uint16_t SwapByteOrder_16(uint16_t value) { inline uint16_t SwapByteOrder_16(uint16_t value) {
#if defined(_MSC_VER) && !defined(_DEBUG) #if defined(_MSC_VER) && !defined(_DEBUG)
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines

lib/Support/Windows/Signals.inc

Show All 22 Lines
#include "llvm/Support/raw_ostream.h" #include "llvm/Support/raw_ostream.h"
// The Windows.h header must be after LLVM and standard headers. // The Windows.h header must be after LLVM and standard headers.
#include "WindowsSupport.h" #include "WindowsSupport.h"
#ifdef __MINGW32__ #ifdef __MINGW32__
#include <imagehlp.h> #include <imagehlp.h>
#else #else
#include <crtdbg.h>
#include <dbghelp.h> #include <dbghelp.h>
#endif #endif
#include <psapi.h> #include <psapi.h>
#ifdef _MSC_VER #ifdef _MSC_VER
#pragma comment(lib, "psapi.lib") #pragma comment(lib, "psapi.lib")
#elif __MINGW32__ #elif __MINGW32__
#if (HAVE_LIBPSAPI != 1) #if (HAVE_LIBPSAPI != 1)
▲ Show 20 Lines • Show All 808 Lines • Show Last 20 Lines