Page MenuHomePhabricator

[XRay] [compiler-rt] Fix format string; sanitizers' internal printf() doesn't support %ld.
ClosedPublic

Authored by pelikan on Dec 17 2016, 8:52 PM.

Details

Summary

Getting rid of the distance number altogether because:

  • a person knowledgeable enough to know what the message means will also know how to do hexadecimal math (with the help of a calculator)
  • numbers outside INT_MIN - INT_MAX are hard to comprehend anyway

This unbreaks the case when you dynamically link a library with XRay and
it exits pre-main() with a not very informative static string.

Diff Detail

Repository
rL LLVM

Event Timeline

pelikan updated this revision to Diff 81871.Dec 17 2016, 8:52 PM
pelikan retitled this revision from to Fix format string; sanitizers' internal printf() doesn't support %ld..
pelikan updated this object.
pelikan added a reviewer: dberris.
pelikan added a subscriber: llvm-commits.
pelikan retitled this revision from Fix format string; sanitizers' internal printf() doesn't support %ld. to [XRay] [compiler-rt] Fix format string; sanitizers' internal printf() doesn't support %ld..Dec 17 2016, 8:54 PM
dberris accepted this revision.Dec 18 2016, 4:56 PM
dberris edited edge metadata.
This revision is now accepted and ready to land.Dec 18 2016, 4:56 PM
This revision was automatically updated to reflect the committed changes.