Page MenuHomePhabricator

Remove lld/Support/Memory.h.
ClosedPublic

Authored by ruiu on Dec 15 2016, 10:30 AM.

Details

Summary

I thought for a while about how to remove it, but it looks like we
can just copy the file for now. Of course I'm not happy about that,
but it's just less than 50 lines of code, and we already have
duplicate code in Error.h and some other places. I want to solve
them all at once later.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu updated this revision to Diff 81614.Dec 15 2016, 10:30 AM
ruiu retitled this revision from to Remove lld/Support/Memory.h..
ruiu updated this object.
ruiu added a reviewer: silvas.
ruiu added a subscriber: llvm-commits.
silvas accepted this revision.Dec 18 2016, 12:12 AM
silvas edited edge metadata.

Thanks for doing this, LGTM with a nit. Overall, it seems that keeping two copies for now is fine, since it is such a small amount of code.

Sorry about pushing so strongly about this, but there is already enough confusion/friction about the "library" vs "program" approach in LLD and I feel strongly that having this in an LLVM-style {include,lib} arrangement was just a little too much.

ELF/Memory.h
19 ↗(On Diff #81614)

Consider adding a mention of the duplication with COFF here.

This revision is now accepted and ready to land.Dec 18 2016, 12:12 AM
This revision was automatically updated to reflect the committed changes.