This is an archive of the discontinued LLVM Phabricator instance.

Update MSVC compat docs about debug info.
ClosedPublic

Authored by thakis on Dec 14 2016, 12:32 PM.

Details

Reviewers
rnk

Diff Detail

Event Timeline

thakis updated this revision to Diff 81437.Dec 14 2016, 12:32 PM
thakis retitled this revision from to Update MSVC compat docs about debug info..
thakis updated this object.
thakis added a reviewer: rnk.
thakis added a subscriber: cfe-commits.
thakis added inline comments.
docs/MSVCCompatibility.rst
80

I believe this is true?

rnk added inline comments.Dec 14 2016, 12:48 PM
docs/MSVCCompatibility.rst
80

You can actually pass -gdwarf to clang-cl to get DWARF. I'm not sure we need to say anything about what happens when you link with DWARF. We mostly want to say that you need to use link.exe to get PDBs today, and that we are working on PDBs in LLD.

thakis added inline comments.Dec 14 2016, 12:52 PM
docs/MSVCCompatibility.rst
80

Huh, it's not in /? output for some reason. Do you know why? Should we fix this? (I'll remove the reference to DWARF here)

thakis updated this revision to Diff 81443.Dec 14 2016, 12:54 PM

no dwarf or gcc mode

rnk added inline comments.Dec 14 2016, 1:04 PM
docs/MSVCCompatibility.rst
77

Are these debuggers modern or are they just debuggers provided by Microsoft? It could be interpreted as a knock against gdb. Maybe we should say: "Windows debuggers that use the Microsoft DIA SDK, such as the Visual Studio debugger"?

thakis added inline comments.Dec 14 2016, 1:07 PM
docs/MSVCCompatibility.rst
77

Dunno, that was already here, I just kept it. Do they all use the DIA SDK? I thought one of them didn't (but I could be making that up)

thakis updated this revision to Diff 81448.Dec 14 2016, 1:08 PM

reword slightly

rnk accepted this revision.Dec 14 2016, 1:11 PM
rnk edited edge metadata.

Thanks!

docs/MSVCCompatibility.rst
77

I thought they did. Anyway, your wording is good.

This revision is now accepted and ready to land.Dec 14 2016, 1:11 PM
thakis closed this revision.Dec 19 2016, 2:52 PM

r289712