This is an archive of the discontinued LLVM Phabricator instance.

Differential D27731

[libFuzzer] Diff 22 - Fix index error in SearchMemory() implementation for Windows.
ClosedPublic

Authored by mpividori on Dec 13 2016, 2:04 PM.

Details

Reviewers
zturner
Commits
rG566cf67e7c39: [libFuzzer] Fix index error in SearchMemory() implementation for Windows.
rL289966: [libFuzzer] Fix index error in SearchMemory() implementation for Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

mpividori updated this revision to Diff 81298.Dec 13 2016, 2:04 PM
mpividori retitled this revision from to [libFuzzer] Diff 22 - Fix index error in SearchMemory() implementation for Windows..
mpividori updated this object.
mpividori added a reviewer: zturner.
mpividori set the repository for this revision to rL LLVM.
mpividori added a subscriber: llvm-commits.
zturner accepted this revision.Dec 13 2016, 2:19 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 2:19 PM
Closed by commit rL289966: [libFuzzer] Fix index error in SearchMemory() implementation for Windows. (authored by mpividori). · Explain WhyDec 16 2016, 9:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Fuzzer/
2 lines

Diff 81770

llvm/trunk/lib/Fuzzer/FuzzerUtilWindows.cpp

Show First 20 Lines • Show All 162 Lines • ▼ Show 20 Linesconst void *SearchMemory(const void *Data, size_t DataLen, const void *Patt,
const char *Cpatt = (const char *)Patt; const char *Cpatt = (const char *)Patt;
if (!Data || !Patt || DataLen == 0 || PattLen == 0 || DataLen < PattLen) if (!Data || !Patt || DataLen == 0 || PattLen == 0 || DataLen < PattLen)
return NULL; return NULL;
if (PattLen == 1) if (PattLen == 1)
return memchr(Data, *Cpatt, DataLen); return memchr(Data, *Cpatt, DataLen);
const char *End = Cdata + DataLen - PattLen; const char *End = Cdata + DataLen - PattLen + 1;
for (const char *It = Cdata; It < End; ++It) for (const char *It = Cdata; It < End; ++It)
if (It[0] == Cpatt[0] && memcmp(It, Cpatt, PattLen) == 0) if (It[0] == Cpatt[0] && memcmp(It, Cpatt, PattLen) == 0)
return It; return It;
return NULL; return NULL;
} }
} // namespace fuzzer } // namespace fuzzer
#endif // LIBFUZZER_WINDOWS #endif // LIBFUZZER_WINDOWS