This is an archive of the discontinued LLVM Phabricator instance.

COFF: Use a bit in SymbolBody to track which symbols are written to the symbol table.
ClosedPublic

Authored by pcc on Dec 9 2016, 5:56 PM.

Details

Summary

Using a set here caused us to take about 1 second longer to write the symbol
table when linking chrome_child.dll. With this I consistently get better
performance on Windows with the new symbol table.

Before r289280 and with r289183 reverted (median of 5 runs): 17.65s
After this change: 17.33s

On Linux things look even better:

Before: 10.700480444s
After: 5.735681610s

Event Timeline

pcc updated this revision to Diff 80987.Dec 9 2016, 5:56 PM
pcc retitled this revision from to COFF: Use a bit in SymbolBody to track which symbols are written to the symbol table..
pcc updated this object.
pcc added a reviewer: ruiu.
pcc added a subscriber: llvm-commits.
ruiu accepted this revision.Dec 11 2016, 11:57 AM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 11 2016, 11:57 AM
This revision was automatically updated to reflect the committed changes.