Fix arguments of trace output in __kmp_push_stack

[vhscampos]

Summary

In the trace output in line 341, the argument placement of variables 'head' and 'tail' were inverted.

[AndreyChurbanov]

Good catch!

Could you also move the KA_TRACE statement above the __kmp_release_bootstrap_lock(). Because currently the printed data may not be related to the pushed task if some other task is pushed between lock releasing and the print itself. Having the print inside critical section would guarantee the relevant data printed.

Thanks, Andrey

[vhscampos]

Moved trace call inside the critical section.

[AndreyChurbanov]

LGTM

Shell I commit the patch on your behalf?

[vhscampos]

Yes, thanks.

runtime/src/kmp_tasking.c

#else
     KMP_DEBUG_ASSERT( TCR_4(thread_data -> td.td_deque_ntasks) < TASK_DEQUE_SIZE(thread_data->td) );
 #endif
 
     thread_data -> td.td_deque[ thread_data -> td.td_deque_tail ] = taskdata;  // Push taskdata
     // Wrap index.
     thread_data -> td.td_deque_tail = ( thread_data -> td.td_deque_tail + 1 ) & TASK_DEQUE_MASK(thread_data->td);
     TCW_4(thread_data -> td.td_deque_ntasks, TCR_4(thread_data -> td.td_deque_ntasks) + 1);             // Adjust task count
 
-    __kmp_release_bootstrap_lock( & thread_data -> td.td_deque_lock );
-
     KA_TRACE(20, ("__kmp_push_task: T#%d returning TASK_SUCCESSFULLY_PUSHED: "
-                  "task=%p ntasks=%d head=%u tail=%u\n",
-                  gtid, taskdata, thread_data->td.td_deque_ntasks,
-                  thread_data->td.td_deque_tail, thread_data->td.td_deque_head) );
+          thread_data->td.td_deque_head, thread_data->td.td_deque_tail) );
+
+    __kmp_release_bootstrap_lock( & thread_data -> td.td_deque_lock );
 
     return TASK_SUCCESSFULLY_PUSHED;
 }
 
 
 //-----------------------------------------------------------------------------------------
 // __kmp_pop_current_task_from_thread: set up current task from called thread when team ends
 // this_thr: thread structure to set current_task in.