This is an archive of the discontinued LLVM Phabricator instance.

COFF: Move a call to toString() out of the hot path.
ClosedPublic

Authored by pcc on Dec 9 2016, 12:59 PM.

Reviewers

Commits

Summary

Profiling revealed that we were spending 5% of our time linking
chrome_child.dll just in this call to toString().

Build Status

Buildable 2028
Build 2028: arc lint + arc unit

pcc retitled this revision from to COFF: Move a call to toString() out of the hot path..

pcc updated this object.

pcc added a reviewer: ruiu.

pcc added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Dec 9 2016, 1:00 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

COFF/

6 lines

	Show First 20 Lines • Show All 165 Lines • ▼ Show 20 Lines
	void ObjectFile::initializeSymbols() {			void ObjectFile::initializeSymbols() {
	uint32_t NumSymbols = COFFObj->getNumberOfSymbols();			uint32_t NumSymbols = COFFObj->getNumberOfSymbols();
	SymbolBodies.reserve(NumSymbols);			SymbolBodies.reserve(NumSymbols);
	SparseSymbolBodies.resize(NumSymbols);			SparseSymbolBodies.resize(NumSymbols);
	SmallVector<std::pair<Undefined *, uint32_t>, 8> WeakAliases;			SmallVector<std::pair<Undefined *, uint32_t>, 8> WeakAliases;
	int32_t LastSectionNumber = 0;			int32_t LastSectionNumber = 0;
	for (uint32_t I = 0; I < NumSymbols; ++I) {			for (uint32_t I = 0; I < NumSymbols; ++I) {
	// Get a COFFSymbolRef object.			// Get a COFFSymbolRef object.
	COFFSymbolRef Sym =			ErrorOr<COFFSymbolRef> SymOrErr = COFFObj->getSymbol(I);
	check(COFFObj->getSymbol(I), "broken object file: " + toString(this));			if (!SymOrErr)
				fatal(SymOrErr.getError(), "broken object file: " + toString(this));
				COFFSymbolRef Sym = *SymOrErr;

	const void *AuxP = nullptr;			const void *AuxP = nullptr;
	if (Sym.getNumberOfAuxSymbols())			if (Sym.getNumberOfAuxSymbols())
	AuxP = COFFObj->getSymbol(I + 1)->getRawPtr();			AuxP = COFFObj->getSymbol(I + 1)->getRawPtr();
	bool IsFirst = (LastSectionNumber != Sym.getSectionNumber());			bool IsFirst = (LastSectionNumber != Sym.getSectionNumber());

	SymbolBody *Body = nullptr;			SymbolBody *Body = nullptr;
	if (Sym.isUndefined()) {			if (Sym.isUndefined()) {
	▲ Show 20 Lines • Show All 220 Lines • Show Last 20 Lines