This is an archive of the discontinued LLVM Phabricator instance.

Differential D27589

[DebugInfo] Relax test case for long double constants.
ClosedPublic

Authored by dgross on Dec 8 2016, 1:10 PM.

Details

Reviewers
pirama
cfe-commits
probinson
Commits
rGbcc6cea748c7: [DebugInfo] Relax test case for long double constants.
rC289103: [DebugInfo] Relax test case for long double constants.
rL289103: [DebugInfo] Relax test case for long double constants.
Summary

D27549 (partial fix for PR26619) emits a constant value in the debug
metadata for a floating-point static const that does not exceed 64
bits in size. The regression test accompanying that fix assumes that
a long double exceeds 64 bits in size and hence does not get a
constant value in the debug metadata. However, for some targets --
such as "--target=hexagon-unknown-elf" -- a long double does not
exceed 64 bits in size, and hence the test fails.

As a temporary fix, modify the regression test to no longer inspect
the debug metadata for a long double.

Diff Detail

Repository
rL LLVM

Event Timeline

dgross updated this revision to Diff 80815.Dec 8 2016, 1:10 PM
dgross retitled this revision from to [DebugInfo] Relax test case for long double constants..
dgross updated this object.
dgross added reviewers: cfe-commits, probinson.
pirama accepted this revision.Dec 8 2016, 1:24 PM
pirama added a reviewer: pirama.
This revision is now accepted and ready to land.Dec 8 2016, 1:24 PM
Closed by commit rL289103: [DebugInfo] Relax test case for long double constants. (authored by dgross). · Explain WhyDec 8 2016, 1:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
CodeGen/
6 lines

Diff 80817

cfe/trunk/test/CodeGen/debug-info-static-const-fp.c

Show All 18 Lines
// CHECK: ![[HEXPR]] = !DIExpression(DW_OP_constu, 16502, DW_OP_stack_value) // CHECK: ![[HEXPR]] = !DIExpression(DW_OP_constu, 16502, DW_OP_stack_value)
// CHECK: !DIGlobalVariable(name: "fVal", {{.*}}, isLocal: true, isDefinition: true, expr: ![[FEXPR:[0-9]+]] // CHECK: !DIGlobalVariable(name: "fVal", {{.*}}, isLocal: true, isDefinition: true, expr: ![[FEXPR:[0-9]+]]
// CHECK: ![[FEXPR]] = !DIExpression(DW_OP_constu, 3238681178, DW_OP_stack_value) // CHECK: ![[FEXPR]] = !DIExpression(DW_OP_constu, 3238681178, DW_OP_stack_value)
// CHECK: !DIGlobalVariable(name: "dVal", {{.*}}, isLocal: true, isDefinition: true, expr: ![[DEXPR:[0-9]+]] // CHECK: !DIGlobalVariable(name: "dVal", {{.*}}, isLocal: true, isDefinition: true, expr: ![[DEXPR:[0-9]+]]
// CHECK: ![[DEXPR]] = !DIExpression(DW_OP_constu, 4658387303597904457, DW_OP_stack_value) // CHECK: ![[DEXPR]] = !DIExpression(DW_OP_constu, 4658387303597904457, DW_OP_stack_value)
// CHECK: !DIGlobalVariable(name: "ldVal", {{.*}}, isLocal: true, isDefinition: true) // Temporarily removing this check -- for some targets (such as
// "--target=hexagon-unknown-elf"), long double does not exceed 64
// bits, and so we actually do get the constant value (expr) emitted.
//
// DO-NOT-CHECK: !DIGlobalVariable(name: "ldVal", {{.*}}, isLocal: true, isDefinition: true)