Page MenuHomePhabricator

dgross (David Gross)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2015, 2:20 PM (208 w, 6 h)

Recent Activity

Jul 25 2017

dgross accepted D35822: [docs] Fix a typo: iteratation -> iteration.
Jul 25 2017, 10:29 AM

Apr 19 2017

dgross committed rL300727: Teach RenderScriptRuntime about changed context representation..
Teach RenderScriptRuntime about changed context representation.
Apr 19 2017, 11:27 AM
dgross closed D32184: Teach RenderScriptRuntime about changed context representation. by committing rL300727: Teach RenderScriptRuntime about changed context representation..
Apr 19 2017, 11:27 AM

Apr 18 2017

dgross added a reviewer for D32184: Teach RenderScriptRuntime about changed context representation.: labath.
Apr 18 2017, 12:36 PM
dgross added a comment to D32184: Teach RenderScriptRuntime about changed context representation..

Context representation changed here: https://android-review.googlesource.com/#/c/343816/

Apr 18 2017, 12:22 PM
dgross created D32184: Teach RenderScriptRuntime about changed context representation..
Apr 18 2017, 12:20 PM

Dec 14 2016

dgross committed rL289686: [DebugInfo] Restore test case for long double constants..
[DebugInfo] Restore test case for long double constants.
Dec 14 2016, 11:03 AM
dgross closed D27597: [DebugInfo] Restore test case for long double constants. by committing rL289686: [DebugInfo] Restore test case for long double constants..
Dec 14 2016, 11:02 AM

Dec 13 2016

dgross updated the diff for D27597: [DebugInfo] Restore test case for long double constants..

Incorporate code review comments.

Dec 13 2016, 3:57 PM
dgross added a comment to D27597: [DebugInfo] Restore test case for long double constants..

As dblaikie said in email, probably better to make this X86-specific; if long-double varies by OS you can put in a specific triple.

Dec 13 2016, 3:20 PM

Dec 12 2016

dgross updated the diff for D27551: [DebugInfo] Add regression test for __fp16, float, and double constants..

Per code review, wrap text paragraph to 80 columns.

Dec 12 2016, 4:54 PM
dgross added inline comments to D27551: [DebugInfo] Add regression test for __fp16, float, and double constants..
Dec 12 2016, 4:51 PM
dgross added a comment to D27551: [DebugInfo] Add regression test for __fp16, float, and double constants..

Does this need the test coverage if it's just "hey, LLVM can splat these bytes out into DWARF even if we (independently) say the type of those bytes is a float"? The code that emits the bytes is presumably independent of the code that emits the type description, so testing the combination seems unnecessary to me.

Dec 12 2016, 3:24 PM

Dec 9 2016

dgross added a comment to D27597: [DebugInfo] Restore test case for long double constants..

I don't know exactly what the RUN syntax supported by lit is. What I've done here looks complex, but it does work for Linux. What about other platforms?

Dec 9 2016, 3:59 AM
dgross retitled D27597: [DebugInfo] Restore test case for long double constants. from to [DebugInfo] Restore test case for long double constants..
Dec 9 2016, 3:59 AM

Dec 8 2016

dgross committed rL289103: [DebugInfo] Relax test case for long double constants..
[DebugInfo] Relax test case for long double constants.
Dec 8 2016, 1:25 PM
dgross closed D27589: [DebugInfo] Relax test case for long double constants. by committing rL289103: [DebugInfo] Relax test case for long double constants..
Dec 8 2016, 1:25 PM
dgross retitled D27589: [DebugInfo] Relax test case for long double constants. from to [DebugInfo] Relax test case for long double constants..
Dec 8 2016, 1:10 PM
dgross committed rL289094: [DebugInfo] Add support for __fp16, float, and double constants..
[DebugInfo] Add support for __fp16, float, and double constants.
Dec 8 2016, 12:13 PM
dgross closed D27549: [DebugInfo] Add support for __fp16, float, and double constants. by committing rL289094: [DebugInfo] Add support for __fp16, float, and double constants..
Dec 8 2016, 12:13 PM

Dec 7 2016

dgross updated the diff for D27551: [DebugInfo] Add regression test for __fp16, float, and double constants..

Incorporate code review feedback.

Dec 7 2016, 6:14 PM
dgross added inline comments to D27549: [DebugInfo] Add support for __fp16, float, and double constants..
Dec 7 2016, 3:59 PM
dgross updated the diff for D27549: [DebugInfo] Add support for __fp16, float, and double constants..

Incorporate code review feedback.

Dec 7 2016, 3:57 PM
dgross added a comment to D27549: [DebugInfo] Add support for __fp16, float, and double constants..

See llvm regression test here: https://reviews.llvm.org/D27551

Dec 7 2016, 3:13 PM
dgross retitled D27551: [DebugInfo] Add regression test for __fp16, float, and double constants. from to [DebugInfo] Add regression test for __fp16, float, and double constants..
Dec 7 2016, 3:09 PM
dgross retitled D27549: [DebugInfo] Add support for __fp16, float, and double constants. from to [DebugInfo] Add support for __fp16, float, and double constants..
Dec 7 2016, 3:07 PM

Dec 2 2016

dgross resigned from D27359: [llvm] Fix D26214: Move error handling out of MC and to the callers..
Dec 2 2016, 12:02 PM
dgross resigned from D27360: [clang] Fix D26214: Move error handling out of MC and to the callers..
Dec 2 2016, 12:01 PM · Restricted Project

Jul 23 2015

dgross committed rL243052: [ARM] Register (existing) ARMLoadStoreOpt pass with LLVM pass manager..
[ARM] Register (existing) ARMLoadStoreOpt pass with LLVM pass manager.
Jul 23 2015, 3:13 PM
dgross closed D11373: [ARM] Register (existing) ARMLoadStoreOpt pass with LLVM pass manager. by committing rL243052: [ARM] Register (existing) ARMLoadStoreOpt pass with LLVM pass manager..
Jul 23 2015, 3:13 PM
dgross committed rL243046: Test commit..
Test commit.
Jul 23 2015, 2:46 PM

Jul 20 2015

dgross retitled D11373: [ARM] Register (existing) ARMLoadStoreOpt pass with LLVM pass manager. from to [ARM] Register (existing) ARMLoadStoreOpt pass with LLVM pass manager..
Jul 20 2015, 3:00 PM