This is an archive of the discontinued LLVM Phabricator instance.

Move DwarfGenerator.cpp to unittests
ClosedPublic

Authored by djasper on Dec 8 2016, 4:02 AM.

Details

Reviewers
bkramer
Summary

So far it creates a test helper and so it should be moved there. It also create a layering cycle between CodeGen and CodeGen/AsmPrinter, which should be avoided.

Diff Detail

Event Timeline

djasper updated this revision to Diff 80742.Dec 8 2016, 4:02 AM
djasper retitled this revision from to Move DwarfGenerator.cpp to unittests.
djasper updated this object.
djasper added a reviewer: bkramer.
djasper added a subscriber: llvm-commits.
bkramer accepted this revision.Dec 8 2016, 4:53 AM
bkramer edited edge metadata.

The include through ../lib is still ugly, but I believe resolving the cyclic dependency between codegen and asmparser is more important. It also avoids paying the cost of compiling testing code for every LLVM build even though it's not used in LLVM itself.

This revision is now accepted and ready to land.Dec 8 2016, 4:53 AM
djasper closed this revision.Dec 8 2016, 4:59 AM

Submitted as r289044.