This is an archive of the discontinued LLVM Phabricator instance.

Loosen checks for _MSC_FULL_VER under -fms-extensions.
ClosedPublic

Authored by dlj on Dec 7 2016, 5:10 PM.

Details

Summary

On actual Windows hosts :-) , this could report something other than the
fallback, with a non-zero minor/build number.

Diff Detail

Repository
rL LLVM

Event Timeline

dlj updated this revision to Diff 80690.Dec 7 2016, 5:10 PM
dlj updated this revision to Diff 80691.
dlj retitled this revision from to Loosen checks for _MSC_FULL_VER under -fms-extensions..
dlj added reviewers: rnk, llvm-commits.
dlj updated this object.

Look for at least one number, I guess.

rnk accepted this revision.Dec 7 2016, 5:19 PM
rnk edited edge metadata.

Makes sense, it's probably finding cl.exe on PATH.

This revision is now accepted and ready to land.Dec 7 2016, 5:19 PM
This revision was automatically updated to reflect the committed changes.