This is an archive of the discontinued LLVM Phabricator instance.

Differential D27496

[ELF] Only binaries should have DT_DEBUG entry
ClosedPublic

Authored by phosek on Dec 6 2016, 5:38 PM.

Details

Reviewers
ruiu
Commits
rG668bebed6d5a: [ELF] Only binaries should have DT_DEBUG entry
rLLD288877: [ELF] Only binaries should have DT_DEBUG entry
rL288877: [ELF] Only binaries should have DT_DEBUG entry
Summary

The presence of DT_DEBUG entry is unrelated to the existence of entry point.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 80517.Dec 6 2016, 5:38 PM
phosek retitled this revision from to [ELF] Only binaries should have DT_DEBUG entry.
phosek updated this object.
phosek added a reviewer: ruiu.
phosek set the repository for this revision to rL LLVM.
phosek added a project: lld.
phosek added a subscriber: llvm-commits.
ruiu added inline comments.Dec 6 2016, 5:41 PM
ELF/SyntheticSections.cpp
798 ↗(On Diff #80517)

Do you actually want to exclude DSOs?

phosek added inline comments.Dec 6 2016, 5:53 PM
ELF/SyntheticSections.cpp
798 ↗(On Diff #80517)

Yes, only leafs (that is statically or dynamically linked executables) should have DT_DEBUG entry so this should be correct.

ruiu accepted this revision.Dec 6 2016, 5:56 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 6 2016, 5:56 PM
Closed by commit rL288877: [ELF] Only binaries should have DT_DEBUG entry (authored by phosek). · Explain WhyDec 6 2016, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
ELF/
2 lines

Diff 80525

lld/trunk/ELF/SyntheticSections.cpp

Show First 20 Lines • Show All 789 Lines • ▼ Show 20 Lines if (Config->ZOrigin) {
DtFlags1 |= DF_1_ORIGIN; DtFlags1 |= DF_1_ORIGIN;
} }
if (DtFlags) if (DtFlags)
add({DT_FLAGS, DtFlags}); add({DT_FLAGS, DtFlags});
if (DtFlags1) if (DtFlags1)
add({DT_FLAGS_1, DtFlags1}); add({DT_FLAGS_1, DtFlags1});
if (!Config->Entry.empty()) if (!Config->Shared && !Config->Relocatable)
add({DT_DEBUG, (uint64_t)0}); add({DT_DEBUG, (uint64_t)0});
} }
// Add remaining entries to complete .dynamic contents. // Add remaining entries to complete .dynamic contents.
template <class ELFT> void DynamicSection<ELFT>::finalize() { template <class ELFT> void DynamicSection<ELFT>::finalize() {
if (this->Size) if (this->Size)
return; // Already finalized. return; // Already finalized.
▲ Show 20 Lines • Show All 1,015 Lines • Show Last 20 Lines