This is an archive of the discontinued LLVM Phabricator instance.

[builtin] Add Thumb1 implementation for idivsi3 and aeabi_idivmod
ClosedPublic

Authored by weimingz on Dec 6 2016, 10:53 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

weimingz updated this revision to Diff 80449.Dec 6 2016, 10:53 AM
weimingz retitled this revision from to [builtin] Add Thumb1 implementation for idivsi3 and aeabi_idivmod.
weimingz updated this object.
weimingz added reviewers: rengolin, compnerd.
weimingz added a subscriber: llvm-commits.
compnerd accepted this revision.Dec 7 2016, 9:18 AM
compnerd edited edge metadata.
compnerd added inline comments.
lib/builtins/arm/aeabi_idivmod.S
29 ↗(On Diff #80449)

Please line up the trailing comments.

This revision is now accepted and ready to land.Dec 7 2016, 9:18 AM
weimingz updated this revision to Diff 80629.Dec 7 2016, 11:02 AM
weimingz edited edge metadata.

fixed format and also manually tested using divsi3_test.c and modified divmodsi4_test.c (calling aeabi_idivmod instead of __divmodsi4)

This revision was automatically updated to reflect the committed changes.