Page MenuHomePhabricator

[llgo] Update to use the latest IR attribute bindings
ClosedPublic

Authored by meadori on Dec 5 2016, 6:02 PM.

Details

Reviewers
pcc
llvm-commits
Summary

A recent commit (r286087) to the LLVM Go bindings that
changed things over to use the new attribute API broke
llgo. This commit updates llgo accordingly.

Diff Detail

Event Timeline

meadori updated this revision to Diff 80363.Dec 5 2016, 6:02 PM
meadori retitled this revision from to [llgo] Update to use the latest IR attribute bindings.
meadori updated this object.
meadori added reviewers: llvm-commits, pcc.
pcc added inline comments.Dec 5 2016, 6:22 PM
irgen/attribute.go
157

We probably don't want to allow arbitrary attributes here. (In fact, I would be happy to see this feature removed entirely; it is untested and exposes too many LLVM specifics.)

meadori added inline comments.Dec 5 2016, 6:49 PM
irgen/attribute.go
157

Agreed. Okay if I constrain the attribute application for now and remove the feature in a follow-on commit?

pcc added inline comments.Dec 5 2016, 7:02 PM
irgen/attribute.go
157

SGTM

meadori updated this revision to Diff 80375.Dec 5 2016, 7:07 PM

Address review feedback about constraining LLVM attribute application.

pcc accepted this revision.Dec 5 2016, 8:02 PM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 5 2016, 8:02 PM