This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.
ClosedPublic

Authored by echuraev on Dec 5 2016, 12:25 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

echuraev updated this revision to Diff 80233.Dec 5 2016, 12:25 AM
echuraev retitled this revision from to [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0..
echuraev updated this object.
echuraev added a reviewer: Anastasia.
echuraev added subscribers: bader, cfe-commits, yaxunl.
Anastasia added inline comments.Dec 5 2016, 8:35 AM
test/CodeGenOpenCL/address-spaces-mangling.cl
36 ↗(On Diff #80233)

Just trying to understand what we are missing in the current testing. Does the additional code test something different from the previous one? Could we reuse the old test but just run it with the other OpenCL versions?

Also do we have any different behavior in the mangler depending on OpenCL versions?

echuraev updated this revision to Diff 80401.Dec 6 2016, 3:21 AM
echuraev marked an inline comment as done.
Anastasia accepted this revision.Dec 6 2016, 11:10 AM
Anastasia edited edge metadata.

LGTM! Thanks!

This revision is now accepted and ready to land.Dec 6 2016, 11:10 AM
This revision was automatically updated to reflect the committed changes.