Page MenuHomePhabricator

[libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality
AbandonedPublic

Authored by skalinichev on Dec 3 2016, 5:32 AM.

Details

Reviewers
None
Summary

This was accidentally broken in r287024

Diff Detail

Event Timeline

skalinichev updated this revision to Diff 80178.Dec 3 2016, 5:32 AM
skalinichev retitled this revision from to [libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality.
skalinichev updated this object.
skalinichev added a subscriber: cfe-commits.
skalinichev updated this revision to Diff 80179.Dec 3 2016, 5:33 AM
skalinichev edited edge metadata.
skalinichev added a project: Restricted Project.
skalinichev removed a reviewer: EricWF.
EricWF added a subscriber: EricWF.Dec 3 2016, 5:47 AM

Sorry about Herald adding me as a reviewer. I need to fix my filters.

compnerd added inline comments.
tools/libclang/CXType.cpp
151–153

Isn't this more compact as:

return MakeCXType(A.getKind() == TemplateArgument::Type ? A.getAsType() : QualType(), TU);
961

Why not inline the template arguments?

965

Use auto, the type is obvious.

970

Similar.

skalinichev abandoned this revision.Dec 4 2016, 1:36 AM

Turns out we already have another patch that fixes the same problem: D26907