This is an archive of the discontinued LLVM Phabricator instance.

[change-namespace] don't generate replacements for files that don't match file pattern.
ClosedPublic

Authored by ioeric on Dec 1 2016, 7:27 AM.

Event Timeline

ioeric updated this revision to Diff 79909.Dec 1 2016, 7:27 AM
ioeric retitled this revision from to [change-namespace] don't generate replacements for files that don't match file pattern..
ioeric updated this object.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
hokein accepted this revision.Dec 1 2016, 8:58 AM
hokein edited edge metadata.

LGTM with two nits.

change-namespace/ChangeNamespace.cpp
786

How about creating FilePatternRE from FilePattern here? So that you don't need save FilePatternRE as a member variable.

test/change-namespace/Inputs/macro.h
1

For the simple file like this, I would use echo "#define USING using na::nc::X" > macro.h in macro.cc instead of creating a new file.

This revision is now accepted and ready to land.Dec 1 2016, 8:58 AM
ioeric updated this revision to Diff 79927.Dec 1 2016, 9:28 AM
ioeric marked 2 inline comments as done.
ioeric edited edge metadata.
  • Addressed comments.
This revision was automatically updated to reflect the committed changes.