This is an archive of the discontinued LLVM Phabricator instance.

Bitcode: Correctly handle Fixed and VBR arrays in BitstreamCursor::skipRecord().
ClosedPublic

Authored by pcc on Nov 29 2016, 4:40 PM.

Details

Summary

The assertions were wrong; we need to call getEncodingData() on the element,
not the array. While here, simplify the skipRecord() implementation for Fixed
and Char6 arrays. This is tested by the code I added to llvm-bcanalyzer
which makes sure that we can skip any record.

Event Timeline

pcc updated this revision to Diff 79673.Nov 29 2016, 4:40 PM
pcc retitled this revision from to Bitcode: Correctly handle Fixed and VBR arrays in BitstreamCursor::skipRecord()..
pcc updated this object.
pcc added a reviewer: mehdi_amini.
pcc added a subscriber: llvm-commits.
mehdi_amini accepted this revision.Nov 30 2016, 8:41 PM
mehdi_amini edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Nov 30 2016, 8:41 PM
This revision was automatically updated to reflect the committed changes.