Page MenuHomePhabricator

[ObjC] Encode type arguments in property information string constants
Needs ReviewPublic

Authored by arphaman on Nov 29 2016, 8:22 AM.

Details

Reviewers
rjmccall
ahatanak
Summary

This patch ensures that Objective-C type arguments are included in the string constants that have encoded information about @property declarations.

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman updated this revision to Diff 79575.Nov 29 2016, 8:22 AM
arphaman retitled this revision from to [ObjC] Encode type arguments in property information string constants.
arphaman updated this object.
arphaman added reviewers: rjmccall, ahatanak.
arphaman set the repository for this revision to rL LLVM.
arphaman added a subscriber: cfe-commits.
ahatanak edited edge metadata.Nov 30 2016, 4:31 PM

Do you know whether this patch would have any effect on the objective-c runtime? I suspect it wouldn't cause the runtime to crash, but I don't know how the runtime uses the encoded type information.

Other than that, the changes made in this patch look good to me.

This won't work. The property attribute string consists of comma-separated fields. The encoding used here embeds commas into the type value, which will break parsing of the attribute string. You'll need to use a separator other than a comma.