Page MenuHomePhabricator

Consider nested namespaces in the canonical namespace as canonical as well.
ClosedPublic

Authored by ioeric on Nov 25 2016, 1:08 AM.

Details

Summary

For example, this case was missed when looking for different but canonical
namespaces. UseContext in this case should be considered as in the canonical
namespace.

namespace a { namespace b { <FromContext> } }
namespace a { namespace b { namespace c { <UseContext> } } }

Added some commenting.

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric updated this revision to Diff 79282.Nov 25 2016, 1:08 AM
ioeric retitled this revision from to Consider nested namespaces in the canonical namespace as canonical as well..
ioeric updated this object.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
bkramer added inline comments.Nov 25 2016, 2:49 AM
lib/Tooling/Core/Lookup.cpp
27 ↗(On Diff #79282)

GetNextNamedNamespace

Test email sender.

Testing sender again

ioeric updated this revision to Diff 79295.Nov 25 2016, 3:58 AM
ioeric marked an inline comment as done.
  • Address review comment.
bkramer accepted this revision.Nov 25 2016, 4:11 AM
bkramer edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2016, 4:11 AM
This revision was automatically updated to reflect the committed changes.