Page MenuHomePhabricator

Fix crash when using __has_nothrow_copy with inherited constructors
AbandonedPublic

Authored by blastrock on Nov 24 2016, 2:58 PM.

Details

Summary

Fixes PR30491

Diff Detail

Event Timeline

blastrock updated this revision to Diff 79262.Nov 24 2016, 2:58 PM
blastrock retitled this revision from to Fix crash when using __has_nothrow_copy with inherited constructors.
blastrock updated this object.
blastrock added reviewers: CornedBee, aaron.ballman.
blastrock added a subscriber: llvm-commits.

I'm new to this and I'm not sure at all this is the correct way to fix it. Any input is welcome :)

blastrock updated this revision to Diff 79319.Nov 25 2016, 12:56 PM

I got what "shadows" means, this patch can handle a UsingDecl with multiple shadows.

majnemer edited subscribers, added: cfe-commits; removed: llvm-commits.
rsmith edited edge metadata.Nov 25 2016, 4:26 PM

Do we still need this after D23765 lands?

blastrock abandoned this revision.Nov 26 2016, 4:04 AM

No, D23765 seems to fix this issue.