This is an archive of the discontinued LLVM Phabricator instance.

Differential D27020

[libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 7/12.
ClosedPublic

Authored by STL_MSFT on Nov 22 2016, 4:50 PM.

Details

Reviewers
mclow.lists
EricWF
Summary

[libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 7/12.

When initializing unsigned integers to their maximum values, change "const T M(~0);" to "const T M(static_cast<T>(-1));".

~0 and -1 are equivalent, but I consider the -1 form to be significantly clearer (and more consistent with other tests).

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 78989.Nov 22 2016, 4:50 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 7/12..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Herald edited edge metadata. · View Herald TranscriptNov 22 2016, 4:50 PM
EricWF accepted this revision.Nov 22 2016, 10:47 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 10:47 PM
STL_MSFT mentioned this in rL287827: [libcxx] [test] D27020: Fix MSVC warning C4245 "conversion from 'X' to 'Y'….Nov 23 2016, 2:13 PM
STL_MSFT closed this revision.Nov 23 2016, 2:17 PM

Thanks, r287827.

Revision Contents

PathSize
test/
std/
numerics/
rand/
rand.eng/
rand.eng.lcong/
2 lines
2 lines
2 lines
2 lines

Diff 78989

test/std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp

Show All 31 Lines
template <class T> template <class T>
void void
test() test()
{ {
test1<T, 0, 0, 0>(); test1<T, 0, 0, 0>();
test1<T, 0, 1, 2>(); test1<T, 0, 1, 2>();
test1<T, 1, 1, 2>(); test1<T, 1, 1, 2>();
const T M(~0); const T M(static_cast<T>(-1));
test1<T, 0, 0, M>(); test1<T, 0, 0, M>();
test1<T, 0, M-2, M>(); test1<T, 0, M-2, M>();
test1<T, 0, M-1, M>(); test1<T, 0, M-1, M>();
test1<T, M-2, 0, M>(); test1<T, M-2, 0, M>();
test1<T, M-2, M-2, M>(); test1<T, M-2, M-2, M>();
test1<T, M-2, M-1, M>(); test1<T, M-2, M-1, M>();
test1<T, M-1, 0, M>(); test1<T, M-1, 0, M>();
test1<T, M-1, M-2, M>(); test1<T, M-1, M-2, M>();
Show All 10 Lines

test/std/numerics/rand/rand.eng/rand.eng.lcong/copy.pass.cpp

Show All 31 Lines
template <class T> template <class T>
void void
test() test()
{ {
test1<T, 0, 0, 0>(); test1<T, 0, 0, 0>();
test1<T, 0, 1, 2>(); test1<T, 0, 1, 2>();
test1<T, 1, 1, 2>(); test1<T, 1, 1, 2>();
const T M(~0); const T M(static_cast<T>(-1));
test1<T, 0, 0, M>(); test1<T, 0, 0, M>();
test1<T, 0, M-2, M>(); test1<T, 0, M-2, M>();
test1<T, 0, M-1, M>(); test1<T, 0, M-1, M>();
test1<T, M-2, 0, M>(); test1<T, M-2, 0, M>();
test1<T, M-2, M-2, M>(); test1<T, M-2, M-2, M>();
test1<T, M-2, M-1, M>(); test1<T, M-2, M-1, M>();
test1<T, M-1, 0, M>(); test1<T, M-1, 0, M>();
test1<T, M-1, M-2, M>(); test1<T, M-1, M-2, M>();
Show All 10 Lines

test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp

Show All 30 Lines
template <class T> template <class T>
void void
test() test()
{ {
test1<T, 0, 0, 0>(); test1<T, 0, 0, 0>();
test1<T, 0, 1, 2>(); test1<T, 0, 1, 2>();
test1<T, 1, 1, 2>(); test1<T, 1, 1, 2>();
const T M(~0); const T M(static_cast<T>(-1));
test1<T, 0, 0, M>(); test1<T, 0, 0, M>();
test1<T, 0, M-2, M>(); test1<T, 0, M-2, M>();
test1<T, 0, M-1, M>(); test1<T, 0, M-1, M>();
test1<T, M-2, 0, M>(); test1<T, M-2, 0, M>();
test1<T, M-2, M-2, M>(); test1<T, M-2, M-2, M>();
test1<T, M-2, M-1, M>(); test1<T, M-2, M-1, M>();
test1<T, M-1, 0, M>(); test1<T, M-1, 0, M>();
test1<T, M-1, M-2, M>(); test1<T, M-1, M-2, M>();
Show All 10 Lines

test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp

Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Lines
template <class T> template <class T>
void void
test() test()
{ {
test1<T, 0, 0, 0>(); test1<T, 0, 0, 0>();
test1<T, 0, 1, 2>(); test1<T, 0, 1, 2>();
test1<T, 1, 1, 2>(); test1<T, 1, 1, 2>();
const T M(~0); const T M(static_cast<T>(-1));
test1<T, 0, 0, M>(); test1<T, 0, 0, M>();
test1<T, 0, M-2, M>(); test1<T, 0, M-2, M>();
test1<T, 0, M-1, M>(); test1<T, 0, M-1, M>();
test1<T, M-2, 0, M>(); test1<T, M-2, 0, M>();
test1<T, M-2, M-2, M>(); test1<T, M-2, M-2, M>();
test1<T, M-2, M-1, M>(); test1<T, M-2, M-1, M>();
test1<T, M-1, 0, M>(); test1<T, M-1, 0, M>();
test1<T, M-1, M-2, M>(); test1<T, M-1, M-2, M>();
Show All 10 Lines