This is an archive of the discontinued LLVM Phabricator instance.

[StructurizeCFG] Add whitespace in getAnalysisUsage.
ClosedPublic

Authored by jlebar on Nov 22 2016, 1:46 PM.

Details

Summary

"addRequired" and "addPreserved" look very similar when squished up next
to each other -- without the newline this code looked to me like it was
addRequired'ing DominatorTreeWrapperPass twice.

Event Timeline

jlebar updated this revision to Diff 78940.Nov 22 2016, 1:46 PM
jlebar retitled this revision from to [StructurizeCFG] Add whitespace in getAnalysisUsage..
jlebar updated this object.
jlebar added a reviewer: arsenm.
jlebar added a subscriber: llvm-commits.
arsenm accepted this revision.Nov 22 2016, 1:49 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 22 2016, 1:49 PM
This revision was automatically updated to reflect the committed changes.