This is an archive of the discontinued LLVM Phabricator instance.

[StructurizeCFG] Use a for-each loop instead of iterators in runOnRegion.
ClosedPublic

Authored by jlebar on Nov 22 2016, 1:44 PM.

Reviewers

Commits

jlebar retitled this revision from to [StructurizeCFG] Use a for-each loop instead of iterators in runOnRegion..

jlebar updated this object.

jlebar added a reviewer: arsenm.

jlebar added a subscriber: llvm-commits.

The original order looks forward to me?

In D26993#603210, @arsenm wrote:

The original order looks forward to me?

Me too -- I dunno what I was thinking. Updated commit message locally and in phab.

LGTM

This revision is now accepted and ready to land.Nov 22 2016, 1:51 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Scalar/

7 lines

Show First 20 Lines • Show All 933 Lines • ▼ Show 20 Lines	if (SkipUniformRegions) {
if (hasOnlyUniformBranches(R, DA)) {		if (hasOnlyUniformBranches(R, DA)) {
DEBUG(dbgs() << "Skipping region with uniform control flow: " << *R << '\n');		DEBUG(dbgs() << "Skipping region with uniform control flow: " << *R << '\n');

// Mark all direct child block terminators as having been treated as		// Mark all direct child block terminators as having been treated as
// uniform. To account for a possible future in which non-uniform		// uniform. To account for a possible future in which non-uniform
// sub-regions are treated more cleverly, indirect children are not		// sub-regions are treated more cleverly, indirect children are not
// marked as uniform.		// marked as uniform.
MDNode *MD = MDNode::get(R->getEntry()->getParent()->getContext(), {});		MDNode *MD = MDNode::get(R->getEntry()->getParent()->getContext(), {});
Region::element_iterator E = R->element_end();		for (RegionNode *E : R->elements()) {
for (Region::element_iterator I = R->element_begin(); I != E; ++I) {		if (E->isSubRegion())
if (I->isSubRegion())
continue;		continue;

if (Instruction *Term = I->getEntry()->getTerminator())		if (Instruction *Term = E->getEntry()->getTerminator())
Term->setMetadata("structurizecfg.uniform", MD);		Term->setMetadata("structurizecfg.uniform", MD);
}		}

return false;		return false;
}		}
}		}

Func = R->getEntry()->getParent();		Func = R->getEntry()->getParent();
Show All 30 Lines