This is an archive of the discontinued LLVM Phabricator instance.

Change the way how we print out line numbers.
ClosedPublic

Authored by ruiu on Nov 20 2016, 3:43 PM.

Details

Summary

LLD's error messages contain line numbers, function names or section names.
Currently they are formatter as follows.

foo.c (32): symbol 'foo' not found
foo.c (function bar): symbol 'foo' not found
foo.c (.text+0x1234): symbol 'foo' not found

This patch changes them so that they are consistent with Clang's output.

foo.c:32: symbol 'foo' not found
foo.c:(function bar): symbol 'foo' not found
foo.c:(.text+0x1234): symbol 'foo' not found

Event Timeline

ruiu updated this revision to Diff 78673.Nov 20 2016, 3:43 PM
ruiu retitled this revision from to Change the way how we print out line numbers..
ruiu updated this object.
ruiu added a reviewer: evgeny777.
ruiu added a subscriber: llvm-commits.
ruiu updated this revision to Diff 78674.Nov 20 2016, 3:46 PM
  • Include the right files
evgeny777 accepted this revision.Nov 21 2016, 1:28 AM
evgeny777 edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 21 2016, 1:28 AM
This revision was automatically updated to reflect the committed changes.