This is an archive of the discontinued LLVM Phabricator instance.

Differential D26825

[libc++] Fix preprocessor guard for overload declaration
ClosedPublic

Authored by smeenai on Nov 17 2016, 6:05 PM.

Details

Reviewers
mclow.lists
EricWF
Commits
rGeb72bbfad4ad: [libc++] Fix preprocessor guard for overload declaration
rCXX287309: [libc++] Fix preprocessor guard for overload declaration
rL287309: [libc++] Fix preprocessor guard for overload declaration
Summary

Fix a typo in the conditional. Caught by going through list of removed
symbols when building with hidden visibility.

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai updated this revision to Diff 78447.Nov 17 2016, 6:05 PM
smeenai retitled this revision from to [libc++] Fix preprocessor guard for overload declaration.
smeenai updated this object.
smeenai added reviewers: mclow.lists, EricWF.
smeenai added a subscriber: cfe-commits.
Herald edited edge metadata. · View Herald TranscriptNov 17 2016, 6:05 PM
smeenai mentioned this in D26823: [libc++] Fix preprocessor guard for overload declaration.Nov 17 2016, 6:06 PM
EricWF accepted this revision.Nov 17 2016, 6:53 PM
EricWF edited edge metadata.

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 17 2016, 6:53 PM
Closed by commit rL287309: [libc++] Fix preprocessor guard for overload declaration (authored by smeenai). · Explain WhyNov 17 2016, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
trunk/
include/
2 lines

Diff 78461

libcxx/trunk/include/new

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
#ifndef _LIBCPP_HAS_NO_SIZED_DEALLOCATION #ifndef _LIBCPP_HAS_NO_SIZED_DEALLOCATION
_LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete(void* __p, std::size_t __sz) _NOEXCEPT; _LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete(void* __p, std::size_t __sz) _NOEXCEPT;
#endif #endif
_LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new[](std::size_t __sz) _THROW_BAD_ALLOC; _LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new[](std::size_t __sz) _THROW_BAD_ALLOC;
_LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new[](std::size_t __sz, const std::nothrow_t&) _NOEXCEPT _NOALIAS; _LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new[](std::size_t __sz, const std::nothrow_t&) _NOEXCEPT _NOALIAS;
_LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete[](void* __p) _NOEXCEPT; _LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete[](void* __p) _NOEXCEPT;
_LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete[](void* __p, const std::nothrow_t&) _NOEXCEPT; _LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete[](void* __p, const std::nothrow_t&) _NOEXCEPT;
#ifdef _LIBCPP_HAS_NO_SIZED_DEALLOCATION #ifndef _LIBCPP_HAS_NO_SIZED_DEALLOCATION
_LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete[](void* __p, std::size_t __sz) _NOEXCEPT; _LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete[](void* __p, std::size_t __sz) _NOEXCEPT;
#endif #endif
#ifndef _LIBCPP_HAS_NO_ALIGNED_ALLOCATION #ifndef _LIBCPP_HAS_NO_ALIGNED_ALLOCATION
_LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new(std::size_t __sz, std::align_val_t) _THROW_BAD_ALLOC; _LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new(std::size_t __sz, std::align_val_t) _THROW_BAD_ALLOC;
_LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new(std::size_t __sz, std::align_val_t, const std::nothrow_t&) _NOEXCEPT _NOALIAS; _LIBCPP_OVERRIDABLE_FUNC_VIS void* operator new(std::size_t __sz, std::align_val_t, const std::nothrow_t&) _NOEXCEPT _NOALIAS;
_LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete(void* __p, std::align_val_t) _NOEXCEPT; _LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete(void* __p, std::align_val_t) _NOEXCEPT;
_LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete(void* __p, std::align_val_t, const std::nothrow_t&) _NOEXCEPT; _LIBCPP_OVERRIDABLE_FUNC_VIS void operator delete(void* __p, std::align_val_t, const std::nothrow_t&) _NOEXCEPT;
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines