This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix an assumption about the state of moved-from std::functions.
ClosedPublic

Authored by STL_MSFT on Nov 17 2016, 1:37 PM.

Details

Summary

[libcxx] [test] Fix an assumption about the state of moved-from std::functions.

The Standard doesn't provide any guarantees beyond "valid but unspecified" for
moved-from std::functions. libcxx moves from small targets and leaves them
there, while MSVC's STL empties out the source. Mark these assertions as
libcxx-specific.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 78415.Nov 17 2016, 1:37 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix an assumption about the state of moved-from std::functions..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Nov 17 2016, 11:01 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 11:01 PM
STL_MSFT closed this revision.Nov 18 2016, 2:05 PM

Thanks, r287382.