[libcxx] [test] allocator<const T> is non-Standard.

[STL_MSFT]

Summary

[libcxx] [test] allocator<const T> is non-Standard.

N4582 17.6.3.5 [allocator.requirements] says that allocators are given
cv-unqualified object types, and N4582 20.9.9 [default.allocator]
implies that allocator<const T> is ill-formed (due to colliding
address() overloads). Therefore, tests for allocator<const T>
should be marked as libcxx-specific (if not removed outright).

[STL_MSFT]

Thanks, r287381.

test/std/utilities/memory/default.allocator/allocator.members/allocate.size.pass.cpp

 // <memory>
 
 // allocator:
 // pointer allocate(size_type n, allocator<void>::const_pointer hint=0);
 
 #include <memory>
 #include <cassert>
 
+#include "test_macros.h"
+
 template <typename T>
 void test_max(size_t count)
 {
     std::allocator<T> a;
     try {
         a.allocate(count);
         assert(false);
     } catch (const std::exception &) {
     }
 }
 
-int main()
+template <typename T>
+void test()
 {
-    {  // Bug 26812 -- allocating too large
-        typedef double T;
-        std::allocator<T> a;
-        test_max<T> (a.max_size() + 1);                // just barely too large
-        test_max<T> (a.max_size() * 2);                // significantly too large
-        test_max<T> (((size_t) -1) / sizeof(T) + 1);   // multiply will overflow
-        test_max<T> ((size_t) -1);                     // way too large
-    }
+    // Bug 26812 -- allocating too large
 
-    {
-        typedef const double T;
-        std::allocator<T> a;
-        test_max<T> (a.max_size() + 1);                // just barely too large
-        test_max<T> (a.max_size() * 2);                // significantly too large
-        test_max<T> (((size_t) -1) / sizeof(T) + 1);   // multiply will overflow
-        test_max<T> ((size_t) -1);                     // way too large
-    }
+int main()
+    test<double>();
+    LIBCPP_ONLY(test<const double>());
 }

test/std/utilities/memory/default.allocator/allocator_types.pass.cpp

 //     template <class U> struct rebind {typedef allocator<U> other;};
 // ...
 // };
 
 #include <memory>
 #include <type_traits>
 #include <cstddef>
 
+#include "test_macros.h"
+
 int main()
 {
     static_assert((std::is_same<std::allocator<char>::size_type, std::size_t>::value), "");
     static_assert((std::is_same<std::allocator<char>::difference_type, std::ptrdiff_t>::value), "");
     static_assert((std::is_same<std::allocator<char>::pointer, char*>::value), "");
     static_assert((std::is_same<std::allocator<char>::const_pointer, const char*>::value), "");
     static_assert((std::is_same<std::allocator<char>::value_type, char>::value), "");
     static_assert((std::is_same<std::allocator<char>::reference, char&>::value), "");
     static_assert((std::is_same<std::allocator<char>::const_reference, const char&>::value), "");
     static_assert((std::is_same<std::allocator<char>::rebind<int>::other,
                                 std::allocator<int> >::value), "");
 
     static_assert((std::is_same<std::allocator<      char>::is_always_equal, std::true_type>::value), "");
-    static_assert((std::is_same<std::allocator<const char>::is_always_equal, std::true_type>::value), "");
+    LIBCPP_STATIC_ASSERT((std::is_same<std::allocator<const char>::is_always_equal, std::true_type>::value), "");
 
     std::allocator<char> a;
     std::allocator<char> a2 = a;
     a2 = a;
     std::allocator<int> a3 = a2;
     ((void)a3);
 }