[libcxx] [test] In random tests, use real static_asserts and silence a warning.

[STL_MSFT]

Summary

[libcxx] [test] In random tests, use real static_asserts and silence a warning.

One test triggers MSVC's warning C4310 "cast truncates constant value".
The code is valid, and yet the warning is valid, so I'm silencing it
through push-disable-pop.

[EricWF]

Fun libc++ fact: We implement almost all of the C++11 library in C++03.

These tests use assert because min() is not constexpr in C++03. If you don't mind please change the tests to:

#if TEST_STD_VER >= 11
static_assert(...);
#else
assert(...);
#endif

Feel free to commit after making those changes.

test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp

44

Warning "4310"? #pragma GCC warning ignored "-Wwarning-name" is so much better. Your compiler is bad and you should feel bad. :-P

[STL_MSFT]

Made the requested changes, committed as r287391 with Eric's approval.

test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp

44

Yeah, but C4310 is so much more searchable on the internet! :-P

test/std/numerics/rand/rand.adapt/rand.adapt.disc/values.pass.cpp

 void where(const _Tp &) {}
 
 void
 test1()
 {
     typedef std::ranlux24 E;
     static_assert((E::block_size == 223), "");
     static_assert((E::used_block == 23), "");
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFF)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFF), "");
     where(E::block_size);
     where(E::used_block);
 }
 
 void
 test2()
 {
     typedef std::ranlux48 E;
     static_assert((E::block_size == 389), "");
     static_assert((E::used_block == 11), "");
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFFFFFFFFull)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFFFFFFFFull), "");
     where(E::block_size);
     where(E::used_block);
 }
 
 int main()
 {
     test1();
     test2();
 }

test/std/numerics/rand/rand.adapt/rand.adapt.ibits/values.pass.cpp

 #include <random>
 #include <type_traits>
 #include <cassert>
 
 void
 test1()
 {
     typedef std::independent_bits_engine<std::ranlux24, 32, unsigned> E;
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFFFF)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFFFF), "");
 }
 
 void
 test2()
 {
     typedef std::independent_bits_engine<std::ranlux48, 64, unsigned long long> E;
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFFFFFFFFFFFFull)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFFFFFFFFFFFFull), "");
 }
 
 int main()
 {
     test1();
     test2();
 }

test/std/numerics/rand/rand.adapt/rand.adapt.shuf/values.pass.cpp

 template <class _Tp>
 void where(const _Tp &) {}
 
 void
 test1()
 {
     typedef std::knuth_b E;
     static_assert(E::table_size == 256, "");
-    /*static_*/assert((E::min() == 1)/*, ""*/);
-    /*static_*/assert((E::max() == 2147483646)/*, ""*/);
+    static_assert((E::min() == 1), "");
+    static_assert((E::max() == 2147483646), "");
     where(E::table_size);
 }
 
 int main()
 {
     test1();
 }

test/std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp

 void
 test1()
 {
     typedef std::linear_congruential_engine<T, a, c, m> LCE;
     typedef typename LCE::result_type result_type;
     static_assert((LCE::multiplier == a), "");
     static_assert((LCE::increment == c), "");
     static_assert((LCE::modulus == m), "");
-    /*static_*/assert((LCE::min() == (c == 0u ? 1u: 0u))/*, ""*/);
-    /*static_*/assert((LCE::max() == result_type(m - 1u))/*, ""*/);
+    static_assert((LCE::min() == (c == 0u ? 1u: 0u)), "");
+
+#ifdef _MSC_VER
+    #pragma warning(push)
+    #pragma warning(disable: 4310) // cast truncates constant value
+#endif // _MSC_VER
+
+    static_assert((LCE::max() == result_type(m - 1u)), "");
+
+#ifdef _MSC_VER
+    #pragma warning(pop)
+#endif // _MSC_VER
+
     static_assert((LCE::default_seed == 1), "");
     where(LCE::multiplier);
     where(LCE::increment);
     where(LCE::modulus);
     where(LCE::default_seed);
 }
 
 template <class T>

test/std/numerics/rand/rand.eng/rand.eng.mers/values.pass.cpp

test1()
     static_assert((E::tempering_u == 11), "");
     static_assert((E::tempering_d == 0xffffffff), "");
     static_assert((E::tempering_s == 7), "");
     static_assert((E::tempering_b == 0x9d2c5680), "");
     static_assert((E::tempering_t == 15), "");
     static_assert((E::tempering_c == 0xefc60000), "");
     static_assert((E::tempering_l == 18), "");
     static_assert((E::initialization_multiplier == 1812433253), "");
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFFFF)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFFFF), "");
     static_assert((E::default_seed == 5489u), "");
     where(E::word_size);
     where(E::state_size);
     where(E::shift_size);
     where(E::mask_bits);
     where(E::xor_mask);
     where(E::tempering_u);
     where(E::tempering_d);
test2()
     static_assert((E::tempering_u == 29), "");
     static_assert((E::tempering_d == 0x5555555555555555ull), "");
     static_assert((E::tempering_s == 17), "");
     static_assert((E::tempering_b == 0x71d67fffeda60000ull), "");
     static_assert((E::tempering_t == 37), "");
     static_assert((E::tempering_c == 0xfff7eee000000000ull), "");
     static_assert((E::tempering_l == 43), "");
     static_assert((E::initialization_multiplier == 6364136223846793005ull), "");
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFFFFFFFFFFFFull)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFFFFFFFFFFFFull), "");
     static_assert((E::default_seed == 5489u), "");
     where(E::word_size);
     where(E::state_size);
     where(E::shift_size);
     where(E::mask_bits);
     where(E::xor_mask);
     where(E::tempering_u);
     where(E::tempering_d);

test/std/numerics/rand/rand.eng/rand.eng.sub/values.pass.cpp

 
 void
 test1()
 {
     typedef std::ranlux24_base E;
     static_assert((E::word_size == 24), "");
     static_assert((E::short_lag == 10), "");
     static_assert((E::long_lag == 24), "");
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFF)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFF), "");
     static_assert((E::default_seed == 19780503u), "");
     where(E::word_size);
     where(E::short_lag);
     where(E::long_lag);
     where(E::default_seed);
 }
 
 void
 test2()
 {
     typedef std::ranlux48_base E;
     static_assert((E::word_size == 48), "");
     static_assert((E::short_lag == 5), "");
     static_assert((E::long_lag == 12), "");
-    /*static_*/assert((E::min() == 0)/*, ""*/);
-    /*static_*/assert((E::max() == 0xFFFFFFFFFFFFull)/*, ""*/);
+    static_assert((E::min() == 0), "");
+    static_assert((E::max() == 0xFFFFFFFFFFFFull), "");
     static_assert((E::default_seed == 19780503u), "");
     where(E::word_size);
     where(E::short_lag);
     where(E::long_lag);
     where(E::default_seed);
 }
 
 int main()
 {
     test1();
     test2();
 }