This is an archive of the discontinued LLVM Phabricator instance.

[sanitizers] specifying style for global constant
ClosedPublic

Authored by aizatsky on Nov 16 2016, 11:11 AM.

Download Raw Diff

Details

Reviewers

kcc
vitalybuka

Commits

rG1e0093eb87e4: [sanitizers] specifying style for global constant
rCRT287268: [sanitizers] specifying style for global constant
rL287268: [sanitizers] specifying style for global constant

Diff Detail

Repository: rL LLVM

Event Timeline

aizatsky updated this revision to Diff 78226.Nov 16 2016, 11:11 AM

aizatsky retitled this revision from to [sanitizers] specifying style for global constant.

aizatsky updated this object.

Herald added a subscriber: kubamracek. · View Herald TranscriptNov 16 2016, 11:11 AM

Kostya, what should be the style for global constants? lower_case is definitely wrong.

LGTM, but leaving to Kostya.

most of this code uses kCamelCase

specifying global constant prefix

PTAL.

It is not a question about the existing code, since clang-tidy integrates with git-diff. It is more about which style you want to enforce for new code.

Sure. I want to keep the existing style.

This revision is now accepted and ready to land.Nov 17 2016, 10:35 AM

Closed by commit rL287268: [sanitizers] specifying style for global constant (authored by aizatsky). · Explain WhyNov 17 2016, 2:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

trunk/

lib/

sanitizer_common/

.clang-tidy

4 lines

Diff 78420

compiler-rt/trunk/lib/sanitizer_common/.clang-tidy

	Checks: '-,clang-diagnostic-,llvm-,misc-,readability-identifier-naming'			Checks: '-,clang-diagnostic-,llvm-,misc-,readability-identifier-naming'
	CheckOptions:			CheckOptions:
	- key: readability-identifier-naming.ClassCase			- key: readability-identifier-naming.ClassCase
	value: CamelCase			value: CamelCase
	- key: readability-identifier-naming.EnumCase			- key: readability-identifier-naming.EnumCase
	value: CamelCase			value: CamelCase
	- key: readability-identifier-naming.FunctionCase			- key: readability-identifier-naming.FunctionCase
	value: CamelCase			value: CamelCase
	- key: readability-identifier-naming.UnionCase			- key: readability-identifier-naming.UnionCase
	value: CamelCase			value: CamelCase
				- key: readability-identifier-naming.GlobalConstantCase
				value: CamelCase
				- key: readability-identifier-naming.GlobalConstantPrefix
				value: "k"
	- key: readability-identifier-naming.VariableCase			- key: readability-identifier-naming.VariableCase
	value: lower_case			value: lower_case