This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix an improper assumption about Null Forward Iterators.
ClosedPublic

Authored by STL_MSFT on Nov 14 2016, 12:09 PM.

Details

Summary

[libcxx] [test] Fix an improper assumption about Null Forward Iterators.

Value-initialized iterators still can't be compared to those with parents.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 77858.Nov 14 2016, 12:09 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix an improper assumption about Null Forward Iterators..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

I could mark these assertions as libcxx-specific, but I tend to believe that they should be removed outright (even if the natural implementation of a list without debug checks provides this behavior).

EricWF accepted this revision.Dec 10 2016, 6:22 PM
EricWF edited edge metadata.

LGTM. Go ahead and remove the tests. I filed a libc++ bug reminding me to diagnose those comparisons in debug mode (https://llvm.org/bugs/show_bug.cgi?id=31343).

This revision is now accepted and ready to land.Dec 10 2016, 6:22 PM
STL_MSFT closed this revision.Dec 12 2016, 12:02 PM