This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Do not create absolute __ehdr_start symbol for relocatable output.
AbandonedPublic

Authored by grimar on Nov 14 2016, 1:55 AM.

Reviewers

ruiu
• rafael

Summary

We should not create absolute symbols when doing relocatable link.
This one continues job started by D26545.

grimar retitled this revision from to [ELF] - Do not create absolute __ehdr_start symbol for relocatable output..

grimar updated this object.

grimar added reviewers: ruiu, • rafael.

grimar added a subscriber: llvm-commits.

grimar added subscribers: grimar, evgeny777.

Abandoned in favour of D26600.

Path

Size

ELF/

3 lines

test/

ELF/

5 lines

Show First 20 Lines • Show All 643 Lines • ▼ Show 20 Lines	template <class ELFT> void Writer<ELFT>::addReservedSymbols() {
if (!Out<ELFT>::DynSymTab &&		if (!Out<ELFT>::DynSymTab &&
(Config->EMachine != EM_MIPS && Config->EMachine != EM_ARM))		(Config->EMachine != EM_MIPS && Config->EMachine != EM_ARM))
Symtab<ELFT>::X->addIgnored("__tls_get_addr");		Symtab<ELFT>::X->addIgnored("__tls_get_addr");

// If linker script do layout we do not need to create any standart symbols.		// If linker script do layout we do not need to create any standart symbols.
if (ScriptConfig->HasSections)		if (ScriptConfig->HasSections)
return;		return;

		if (!Config->Relocatable)
ElfSym<ELFT>::EhdrStart = Symtab<ELFT>::X->addIgnored("__ehdr_start");		ElfSym<ELFT>::EhdrStart = Symtab<ELFT>::X->addIgnored("__ehdr_start");

auto Define = [this](StringRef S, DefinedRegular<ELFT> *&Sym1,		auto Define = [this](StringRef S, DefinedRegular<ELFT> *&Sym1,
DefinedRegular<ELFT> *&Sym2) {		DefinedRegular<ELFT> *&Sym2) {
Sym1 = Symtab<ELFT>::X->addIgnored(S, STV_DEFAULT);		Sym1 = Symtab<ELFT>::X->addIgnored(S, STV_DEFAULT);

// The name without the underscore is not a reserved name,		// The name without the underscore is not a reserved name,
// so it is defined only when there is a reference against it.		// so it is defined only when there is a reference against it.
assert(S.startswith("_"));		assert(S.startswith("_"));
▲ Show 20 Lines • Show All 923 Lines • Show Last 20 Lines

	# REQUIRES: x86			# REQUIRES: x86

	# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o			# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
	# RUN: ld.lld %t.o -o %t			# RUN: ld.lld %t.o -o %t
	# RUN: llvm-objdump -t %t \| FileCheck %s			# RUN: llvm-objdump -t %t \| FileCheck %s
	# CHECK: 0000000000010040 ABS 00000000 .hidden __ehdr_start			# CHECK: 0000000000010040 ABS 00000000 .hidden __ehdr_start

	.text			.text
	.global _start, __ehdr_start			.global _start, __ehdr_start
	_start:			_start:
	.quad __ehdr_start			.quad __ehdr_start

				# RUN: ld.lld -r %t.o -o %t.r
				# RUN: llvm-objdump -t %t.r \| FileCheck %s --check-prefix=RELOCATABLE

				# RELOCATABLE: 0000000000000000 UND 00000000 __ehdr_start