[opt-viewer] PEPify opt-viewer.py

[mgrang]

Adam,

I have not fixed the following pep8 error:

opt-viewer.py:5:80: E501 line too long (84 characters)

As I was not sure if we want these lines wrapped to 80 chars or not:

desc = '''Generate HTML output to visualize optimization records from the YAML files
generated with -fsave-optimization-record and -fdiagnostics-show-hotness.

The tools requires PyYAML and Pygments Python packages.'''

Thanks,
Mandeep

[anemet]

Hi Mandeep, LGTM, thanks very much!!

I think we should fix this too:

In D26535#592565, @mgrang wrote:

Adam,

I have not fixed the following pep8 error:

opt-viewer.py:5:80: E501 line too long (84 characters)

As I was not sure if we want these lines wrapped to 80 chars or not:

desc = '''Generate HTML output to visualize optimization records from the YAML files
generated with -fsave-optimization-record and -fdiagnostics-show-hotness.

The tools requires PyYAML and Pygments Python packages.'''

Thanks,
Mandeep

utils/opt-viewer/opt-viewer.py

 
 parser = argparse.ArgumentParser(description=desc)
 parser.add_argument('yaml_files', nargs='+')
 parser.add_argument('output_dir')
 parser.add_argument('-source-dir', '-s', default='', help='set source directory')
 args = parser.parse_args()
 
 p = subprocess.Popen(['c++filt', '-n'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+
+
 def demangle(name):
     p.stdin.write(name + '\n')
     return p.stdout.readline().rstrip()
 
+
 class Remark(yaml.YAMLObject):
     max_hotness = 1
     # Map function names to their source location for function where inlining happened
     caller_loc = dict()
 
     @property
     def File(self):
         return self.DebugLoc['File']
class Remark(yaml.YAMLObject):
     @property
     def RelativeHotness(self):
         return int(round(self.Hotness * 100 / Remark.max_hotness))
 
     @property
     def key(self):
         return (self.__class__, self.Pass, self.Name, self.File, self.Line, self.Column, self.message)
 
+
 class Analysis(Remark):
     yaml_tag = '!Analysis'
 
     @property
-    def color(self): return "white"
+    def color(self):
+        return "white"
+
 
 class AnalysisFPCommute(Analysis):
     yaml_tag = '!AnalysisFPCommute'
 
+
 class AnalysisAliasing(Analysis):
     yaml_tag = '!AnalysisAliasing'
 
+
 class Passed(Remark):
     yaml_tag = '!Passed'
 
     @property
-    def color(self): return "green"
+    def color(self):
+        return "green"
+
 
 class Missed(Remark):
     yaml_tag = '!Missed'
 
     @property
-    def color(self): return "red"
+    def color(self):
+        return "red"
+
 
 class SourceFileRenderer:
     def __init__(self, filename):
         existing_filename = None
         if os.path.exists(filename):
             existing_filename = filename
         else:
             fn = os.path.join(args.source_dir, filename)

 </table>
 </body>
 </html>''', file=self.stream)
 
     @classmethod
     def html_file_name(cls, filename):
         return filename.replace('/', '_') + ".html"
 
+
 class IndexRenderer:
     def __init__(self):
         self.stream = open(os.path.join(args.output_dir, 'index.html'), 'w')
 
     def render_entry(self, r):
         print('''
 <tr>
 <td><a href={r.Link}>{r.DebugLocString}</a></td>
</tr>''', file=self.stream)
             self.render_entry(remark)
         print('''
 </table>
 </body>
 </html>''', file=self.stream)
 
 
 all_remarks = dict()
-file_remarks  = dict()
+file_remarks = dict()
 
 for input_file in args.yaml_files:
     f = open(input_file)
     docs = yaml.load_all(f)
     for remark in docs:
         if hasattr(remark, 'Hotness'):
             # Avoid duplicated remarks
             if remark.key in all_remarks:
                 continue
             all_remarks[remark.key] = remark
 
-            file_remarks.setdefault(remark.File, dict()).setdefault(remark.Line, []).append(remark);
+            file_remarks.setdefault(remark.File, dict()).setdefault(remark.Line, []).append(remark)
 
             Remark.max_hotness = max(Remark.max_hotness, remark.Hotness)
 
 # Set up a map between function names and their source location for function where inlining happened
 for remark in all_remarks.itervalues():
     if type(remark) == Passed and remark.Pass == "inline" and remark.Name == "Inlined":
         for arg in remark.Args:
             caller = arg.get('Caller')