This is an archive of the discontinued LLVM Phabricator instance.

Handle adding new nested namespace in old namespace.
ClosedPublic

Authored by ioeric on Nov 9 2016, 9:19 AM.

Event Timeline

ioeric updated this revision to Diff 77362.Nov 9 2016, 9:19 AM
ioeric retitled this revision from to Handle adding new nested namespace in old namespace..
ioeric updated this object.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
ioeric updated this revision to Diff 77380.Nov 9 2016, 11:02 AM
  • Added a test case with type references.
hokein accepted this revision.Nov 10 2016, 10:28 AM
hokein edited edge metadata.

LGTM with two nits.

change-namespace/ChangeNamespace.cpp
475

missing a trailing ..

477–487

How about SourceLocation InsertionLoc = Start; so that you don't need else statement below?

This revision is now accepted and ready to land.Nov 10 2016, 10:28 AM
ioeric updated this revision to Diff 77509.Nov 10 2016, 10:33 AM
ioeric edited edge metadata.
  • Address comments.
ioeric updated this revision to Diff 77511.Nov 10 2016, 10:36 AM
  • Merged origin/master
This revision was automatically updated to reflect the committed changes.