This is an archive of the discontinued LLVM Phabricator instance.

Differential D26338

[lldb] Don't build unit tests for unsupported targets
ClosedPublic

Authored by vsk on Nov 6 2016, 6:13 PM.

Details

Reviewers
jasonmolenda
Commits
rG5ea41f30fd47: [lldb] Don't build unit tests for unsupported targets
rLLDB286215: [lldb] Don't build unit tests for unsupported targets
rL286215: [lldb] Don't build unit tests for unsupported targets
Summary

Should fix: https://llvm.org/bugs/show_bug.cgi?id=30928

Diff Detail

Repository
rL LLVM

Event Timeline

vsk updated this revision to Diff 77001.Nov 6 2016, 6:13 PM
vsk retitled this revision from to [lldb] Don't build unit tests for unsupported targets.
vsk updated this object.
vsk added a reviewer: jasonmolenda.
vsk added a subscriber: lldb-commits.
Herald added a subscriber: mgorny. · View Herald TranscriptNov 6 2016, 6:13 PM
jasonmolenda accepted this revision.Nov 7 2016, 1:37 PM
jasonmolenda edited edge metadata.

Thanks Vedant, we always build armv7/arm64/x86 llvm targets with the xcode style lldb/llvm builds so I hadn't seen this problem. Please commit.

This revision is now accepted and ready to land.Nov 7 2016, 1:37 PM
Closed by commit rL286215: [lldb] Don't build unit tests for unsupported targets (authored by vedantk). · Explain WhyNov 7 2016, 10:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
unittests/
UnwindAssembly/
5 lines
InstEmulation/
4 lines

Diff 77148

lldb/trunk/unittests/UnwindAssembly/CMakeLists.txt

if ("X86" IN_LIST LLVM_TARGETS_TO_BUILD)
add_subdirectory(x86) add_subdirectory(x86)
endif()
add_subdirectory(InstEmulation) add_subdirectory(InstEmulation)

lldb/trunk/unittests/UnwindAssembly/InstEmulation/CMakeLists.txt

if ("AArch64" IN_LIST LLVM_TARGETS_TO_BUILD)
add_lldb_unittest(InstEmulationTests TestArm64InstEmulation.cpp) add_lldb_unittest(InstEmulationTests TestArm64InstEmulation.cpp)
endif()